Skip to content

Conversation

@carson2222
Copy link
Contributor

@carson2222 carson2222 commented Sep 5, 2025

Work in progress

TODO:

  • Accept multiple configs
  • Accept multiple inputs in one config
  • Accept multiple outputs in one config

close #1056
close #1995
close #564

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2025

🦋 Changeset detected

Latest commit: c71e0e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 5, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hey-api-docs Ready Ready Preview Comment Oct 6, 2025 2:57am

@carson2222 carson2222 force-pushed the feat--multiple-configs-functionality branch from 2c662b0 to 1450461 Compare September 11, 2025 11:43
@carson2222 carson2222 marked this pull request as ready for review September 11, 2025 11:44
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. feature 🚀 New feature or request labels Sep 11, 2025
@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

❌ Patch coverage is 44.63668% with 320 lines in your changes missing coverage. Please review.
✅ Project coverage is 29.31%. Comparing base (34bc6e7) to head (c71e0e8).
⚠️ Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
packages/openapi-ts/src/createClient.ts 33.54% 105 Missing ⚠️
packages/openapi-ts/src/error.ts 23.52% 65 Missing ⚠️
packages/openapi-ts/src/utils/cli.ts 15.00% 34 Missing ⚠️
packages/openapi-ts/src/generate/tsConfig.ts 2.94% 33 Missing ⚠️
packages/openapi-ts/src/index.ts 54.54% 30 Missing ⚠️
packages/openapi-ts/src/config/init.ts 75.00% 18 Missing ⚠️
...ages/openapi-ts/src/openApi/3.1.x/parser/server.ts 0.00% 9 Missing ⚠️
...ages/openapi-ts/src/openApi/3.0.x/parser/server.ts 22.22% 7 Missing ⚠️
packages/openapi-ts/src/config/output.ts 20.00% 4 Missing ⚠️
packages/openapi-ts/src/utils/logger.ts 0.00% 4 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2602      +/-   ##
==========================================
+ Coverage   26.44%   29.31%   +2.87%     
==========================================
  Files         387      388       +1     
  Lines       37490    37803     +313     
  Branches     1915     2260     +345     
==========================================
+ Hits         9913    11082    +1169     
+ Misses      27564    26691     -873     
- Partials       13       30      +17     
Flag Coverage Δ
unittests 29.31% <44.63%> (+2.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrlubos
Copy link
Member

mrlubos commented Sep 11, 2025

Without digging into the code, are you internally converting all configs to an array? So what was before config is now [config] and users can also do [config] manually or [config1, config2] but it's always an array internally?

@carson2222
Copy link
Contributor Author

Without digging into the code, are you internally converting all configs to an array? So what was before config is now [config] and users can also do [config] manually or [config1, config2] but it's always an array internally?

Basically yes

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 6, 2025
@mrlubos mrlubos merged commit 4f90ded into main Oct 6, 2025
17 checks passed
@mrlubos mrlubos deleted the feat--multiple-configs-functionality branch October 6, 2025 03:06
@hey-api hey-api bot mentioned this pull request Oct 6, 2025
@warrenseine
Copy link
Contributor

warrenseine commented Oct 12, 2025

Hi! This change broke the watch feature. Here, we're assuming the configuration is flat. Here's a tentative fix: #2751.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature 🚀 New feature or request lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request support multiple schemas Generating code based on multiple OpenAPI schemas Multiple configurations/specifying a configuration file

3 participants