-
Notifications
You must be signed in to change notification settings - Fork 0
feat(icons): add acf partial and basic styles for icons #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
giuseppe-hex
wants to merge
1
commit into
main
Choose a base branch
from
feat/icons
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| <?php | ||
|
|
||
| namespace Bloom\Modules\Icon\Fields\Partials; | ||
|
|
||
| use Illuminate\Filesystem\Filesystem; | ||
| use Log1x\AcfComposer\Builder; | ||
| use Log1x\AcfComposer\Partial; | ||
|
|
||
| class Icon extends Partial | ||
| { | ||
| /** | ||
| * The partial field group. | ||
| */ | ||
| public function fields(): Builder | ||
| { | ||
| $icon = Builder::make('icon'); | ||
|
|
||
| $icon | ||
| ->addSelect('icon', [ | ||
| 'label' => 'Icon', | ||
| 'instructions' => 'Select an icon', | ||
| 'choices' => $this->getIcons(), | ||
| 'allow_null' => 0, | ||
| 'ui' => 1, | ||
| 'ajax' => 1, | ||
| ]); | ||
|
|
||
| return $icon; | ||
| } | ||
|
|
||
| protected function getIcons(): array | ||
| { | ||
| $filesystem = new Filesystem(); | ||
| $files = $filesystem->allFiles(get_template_directory() . '/resources/images/icons'); | ||
|
|
||
| if (!$files) { | ||
| return []; | ||
| } | ||
|
|
||
| $icons = []; | ||
|
|
||
| foreach ($files as $file) { | ||
| $iconValue = $file->getFilenameWithoutExtension(); | ||
| $iconLabel = ucwords($file->getFilenameWithoutExtension()); | ||
| $icons[$iconValue] = $iconLabel; | ||
| } | ||
|
|
||
| return $icons ?? []; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| .c-icon { | ||
| &--up { | ||
| tranform: rotate(0); | ||
| } | ||
|
|
||
| &--right { | ||
| transform: rotate(45deg); | ||
| } | ||
|
|
||
| &--down { | ||
| transform: rotate(180deg); | ||
| } | ||
|
|
||
| &--left { | ||
| transform: rotate(270deg); | ||
| } | ||
| } | ||
|
Comment on lines
+1
to
+17
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need these classes or can we just use tailwind? e.g.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can, I'm just being verbose/OCD about naming 😅 I'll remove. |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to use a Bloom config, and set this in there?
I can foresee an easier time updating repositories in future as Bloom evolves if we have per-app configuration for this, rather than putting it in separate files.
We have a config directory already, is it possible to use that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jamiewarb Are you referring to the file path specifically? If so, yeah that makes sense 💪