Skip to content

feat!: upgrade to oclif/core v4 #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 13, 2025
Merged

feat!: upgrade to oclif/core v4 #180

merged 13 commits into from
May 13, 2025

Conversation

eablack
Copy link
Contributor

@eablack eablack commented May 9, 2025

W-18293658
W-18293803
W-18293826

Description

1 Major Updates:

  • Migrated to oclif/core v4
  • Upgraded to ESLint 8 with rule fixes
  • Switched from Yarn to npm package manager
  • Updated various dependencies

2 Configuration Changes:

  • Added conventional-changelog-cli which will be run on every publish and add entries to CHANGELOG.md
  • Added .eslintrc.js (replacing .eslintrc)
  • Updated .github/workflows/ci.yml
  • Modified .github/dependabot.yml
  • Added .github/CODEOWNERS
  • Removed .circleci/config.yml

3 Code Changes:

  • Added examples/run.sh to run example commands
  • Modified multiple source files in src/ directory
  • Updated test files to match the new changes
  • Removed yarn.lock

4 Documentation and Examples:

  • Updated README.md
  • Modified example files (examples/login.ts, examples/logout.ts) and added new ones
  • Added conventional changelog support

5 Package Management:

  • Switched from Yarn to npm
  • Updated various dependencies in package.json
  • Added package-lock.json
  • Removed yarn.lock

Testing

Nothing in our CLI is using the oclif/core v4 yet. However, I have add several example commands that can be tested via a newly created helper via:

  1. Pull down this branch and npm install
  2. npm run example EXAMPLE_COMMAND where EXAMPLE_COMMAND is one of the commands in ./examples

@eablack eablack marked this pull request as ready for review May 12, 2025 18:24
@eablack eablack requested a review from a team as a code owner May 12, 2025 18:24
Copy link
Contributor

@k80bowman k80bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a TON of great improvements in here, thank you for going through all of this. I have one potential improvement, but it's not blocking. Great work!

@eablack eablack merged commit ca0667b into main May 13, 2025
6 checks passed
@eablack eablack deleted the eb/upgrade-to-oclif-core-4 branch May 13, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants