Move listener declaration out of the lambda.#165
Open
ArekMiszcz wants to merge 1 commit intoheroiclabs:masterfrom
Open
Move listener declaration out of the lambda.#165ArekMiszcz wants to merge 1 commit intoheroiclabs:masterfrom
ArekMiszcz wants to merge 1 commit intoheroiclabs:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a segmentation fault error by moving the declaration of the NRtDefaultClientListener out of the lambda, thereby ensuring its lifetime extends for the duration of the asynchronous callbacks.
- Moved listener declaration to the outer scope.
- Updated lambda capture list to include the listener.
Comments suppressed due to low confidence (1)
example/main.cpp:73
- Ensure that the listener's lifetime covers the entire duration needed for asynchronous callbacks, as capturing it by reference may lead to lifetime issues if the surrounding scope ends early.
auto loginSucceededCallback = [&done, &connectSucceededCallback, &rtErrorCallback, &client, &rtClient, &listener](Nakama::NSessionPtr session) {
RicardRC
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With current shape, an example is throwing segmentation fault error so people rising new issues.
This simple fix solving that problem into this example.