Skip to content

WIP: crate: Added Ping method #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

WIP: crate: Added Ping method #18

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fbfe7a1
crate: Added Ping method
pdxjohnny Sep 29, 2017
f634f54
crate: Ping: Commented on how Ping method works
pdxjohnny Sep 29, 2017
7796f7f
crate: Uses http client and parses from URL
pdxjohnny Oct 1, 2017
4adf1c6
crate: Naming convention Url -> URL
pdxjohnny Oct 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions crate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package crate

import (
"bytes"
"context"
"database/sql"
"database/sql/driver"
"encoding/json"
Expand All @@ -10,6 +11,7 @@ import (
"io"
"net/http"
"net/url"
"strings"
)

// Crate conn structure
Expand All @@ -33,6 +35,14 @@ func (c *CrateDriver) Open(crate_url string) (driver.Conn, error) {
return c, nil
}

func (c *CrateDriver) Ping(ctx context.Context) error {
Copy link

@sourcelevel-bot sourcelevel-bot bot Sep 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported method CrateDriver.Ping should have comment or be unexported

Copy link
Author

@johnandersen777 johnandersen777 Sep 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oooooo fancy

_, err := c.Exec("SELECT name FROM sys.cluster", nil)
if err != nil && strings.Contains(err.Error(), "dial tcp") {
return fmt.Errorf("Could not connect to crate at %s", c.Url)
}
return err
}

// JSON endpoint response struct
// We expect error to be null or ommited
type endpointResponse struct {
Expand Down