Skip to content

feat(keybindings): allow configured double-prefix actions - #2825

Closed
drakejwong wants to merge 1 commit into
herdrdev:masterfrom
drakejwong:feat/configurable-double-prefix
Closed

feat(keybindings): allow configured double-prefix actions#2825
drakejwong wants to merge 1 commit into
herdrdev:masterfrom
drakejwong:feat/configurable-double-prefix

Conversation

@drakejwong

Copy link
Copy Markdown

Summary

  • allow an explicit user keybinding whose prefix-mode key equals keys.prefix
  • dispatch configured prefix actions before falling back to literal double-prefix passthrough
  • preserve Escape precedence and the existing passthrough behavior when no override is configured

This enables configurations such as:

[keys]
prefix = "ctrl+s"
zoom = "prefix+ctrl+s"

Tests

  • cargo fmt --check
  • cargo test --bin herdr double_prefix
  • cargo test --bin herdr escape_precedes_configured_prefix_action
  • cargo test --bin herdr config::keybinds::tests
  • cargo test --bin herdr app::input::navigate::tests

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • ai-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f98b54ce-04d6-4163-b013-a329029adacd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kangal-bot

Copy link
Copy Markdown
Collaborator

Hi @drakejwong, thanks for your interest in contributing.

Herdr does not accept unsolicited implementation pull requests from contributors who are not listed in .github/APPROVED_CONTRIBUTORS.

The pull request author is not an approved contributor.

If you encountered a reproducible bug, report the observed behavior through the bug issue template. A report does not reserve the work or authorize a pull request; accepted fixes are normally implemented by Herdr’s maintainer-controlled agents.

Feature requests, behavior changes, and other proposals belong in GitHub Discussions. Do not open an issue merely to justify an implementation that was already written.

If a maintainer explicitly wants this implementation, they can reopen the pull request. Reopening by anyone else will be closed again automatically.

See https://github.com/herdrdev/herdr/blob/master/CONTRIBUTING.md for the contribution policy.

@kangal-bot kangal-bot closed this Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants