feat(ui): wheel over sidebar switches agent or workspace - #2787
feat(ui): wheel over sidebar switches agent or workspace#2787qiansekai wants to merge 3 commits into
Conversation
|
Hi @qiansekai, thanks for your interest in contributing. Herdr does not accept unsolicited implementation pull requests from contributors who are not listed in The pull request author is not an approved contributor. If you encountered a reproducible bug, report the observed behavior through the bug issue template. A report does not reserve the work or authorize a pull request; accepted fixes are normally implemented by Herdr’s maintainer-controlled agents. Feature requests, behavior changes, and other proposals belong in GitHub Discussions. Do not open an issue merely to justify an implementation that was already written. If a maintainer explicitly wants this implementation, they can reopen the pull request. Reopening by anyone else will be closed again automatically. See https://github.com/herdrdev/herdr/blob/master/CONTRIBUTING.md for the contribution policy. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
feat(ui): wheel over sidebar switches agent or workspace
Problem
Scroll wheel over the sidebar does not switch focus:
move_selected_workspace_by_visible_delta) without switching the active workspace, so nothing visibly changes in the main area.Change
cycle_agent_entry/next_workspace/previous_workspacelogic (previously#[cfg(test)]only) for wheel input.switchmode (default), wheel over the sidebar cycles focus, consistent with wheel-over-tab-bar: agent panel → focus next/prev agent; workspace area → switch next/prev active workspace. Wraps around.scrollmode, the previous behavior (scroll list content / move highlight) is preserved.Config
Tests
wheel_over_agent_panel_switches_agentwheel_over_workspace_list_switches_workspacewheel_scroll_mode_preserves_scrolling