Skip to content

feat: add unified agent conversations - #2672

Closed
marcelormendes wants to merge 1 commit into
herdrdev:masterfrom
marcelormendes:agent/unified-agent-chat
Closed

feat: add unified agent conversations#2672
marcelormendes wants to merge 1 commit into
herdrdev:masterfrom
marcelormendes:agent/unified-agent-chat

Conversation

@marcelormendes

Copy link
Copy Markdown

Summary

  • add a provider-neutral conversation API with stable turn, message, plan, tool, file-change, approval, and attachment models
  • add Codex, Claude, Pi, and Oh My Pi transcript adapters plus bounded live overlays
  • add authenticated attachment staging, prompt submission, approval responses, subscriptions, and restored-pane identity continuity
  • preserve compatibility for clients and panes that do not advertise conversation capability

Validation

  • just check with pinned Rust 1.96.1
  • 3,496 Rust tests passed, 1 skipped
  • strict Unix and Windows-target Clippy passed
  • UI hot-path, integration-asset, marketplace, and 98 maintenance tests passed
  • live-tested through Herdr Desktop against a Pi conversation, including streaming tools, elapsed working state, image paste, approvals, scrolling, and degraded-mode behavior

Context

This is the engine half of the unified agent chat experience implemented and dogfooded in Herdr Desktop.

@kangal-bot

Copy link
Copy Markdown
Collaborator

Hi @marcelormendes, thanks for your interest in contributing.

Herdr does not accept unsolicited implementation pull requests from contributors who are not listed in .github/APPROVED_CONTRIBUTORS.

The pull request author is not an approved contributor.

If you encountered a reproducible bug, report the observed behavior through the bug issue template. A report does not reserve the work or authorize a pull request; accepted fixes are normally implemented by Herdr’s maintainer-controlled agents.

Feature requests, behavior changes, and other proposals belong in GitHub Discussions. Do not open an issue merely to justify an implementation that was already written.

If a maintainer explicitly wants this implementation, they can reopen the pull request. Reopening by anyone else will be closed again automatically.

See https://github.com/herdrdev/herdr/blob/master/CONTRIBUTING.md for the contribution policy.

@kangal-bot kangal-bot closed this Aug 11, 2026
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • ai-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d3aaf0e8-ec5c-420d-9aef-e49d80e7e335

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants