Skip to content

fix: detect codex model capacity errors as blocked - #2342

Open
woodgear wants to merge 1 commit into
herdrdev:masterfrom
woodgear:fix/codex-capacity-blocked
Open

fix: detect codex model capacity errors as blocked#2342
woodgear wants to merge 1 commit into
herdrdev:masterfrom
woodgear:fix/codex-capacity-blocked

Conversation

@woodgear

@woodgear woodgear commented Aug 5, 2026

Copy link
Copy Markdown

Summary

  • classify Codex model-capacity errors as blocked
  • limit matching to the bottom three non-empty lines so stale errors remain idle
  • publish the updated Codex detection manifest

Validation

  • captured the affected pane with herdr agent read <pane> --source detection --format text
  • stock Herdr 0.7.5 classified the captured screen as idle; the patched bundled manifest classifies it as blocked
  • just ci (Rust 1.96.1, Zig 0.15.2): 3,217 Rust tests, 19 integration asset tests, and 24 plugin marketplace tests passed
  • python3 scripts/agent_detection_manifest_check.py --require-website

@kangal-bot kangal-bot added the ai-review Trigger automated AI reviews for pull requests admitted by the PR gate label Aug 5, 2026
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The Codex manifests now detect model-capacity messages as visible blockers. Tests verify blocked detection without activity and stale handling when activity indicators are present.

Changes

Codex capacity detection

Layer / File(s) Summary
Add the capacity-blocked rule
src/detect/manifests/codex.toml, website/agent-detection/codex.toml
Both Codex manifests add the model_capacity_blocked rule for capacity messages in the bottom three non-empty lines. Both manifests update their version and timestamp.
Validate blocked and stale states
src/detect/manifest/tests.rs
Tests verify visible blocked detection without activity and stale idle detection when activity history is present.

Estimated code review effort: 3 (Moderate) | ~20 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the primary change: detecting Codex model-capacity errors as blocked.
Description check ✅ Passed The description directly explains the detection change, matching behavior, manifest update, and validation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ecbd1553-4b96-4d3c-9778-7db59ece392f

📥 Commits

Reviewing files that changed from the base of the PR and between 15442a2 and 30b472c.

📒 Files selected for processing (3)
  • src/detect/manifest/tests.rs
  • src/detect/manifests/codex.toml
  • website/agent-detection/codex.toml

Comment thread src/detect/manifests/codex.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Trigger automated AI reviews for pull requests admitted by the PR gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants