Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix seg-fault issues when initializing NEST #30

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

med-ayssar
Copy link

fixes #3400

@med-ayssar
Copy link
Author

@heplesser, in testsuite/do_tests, I just removed the line with mpi command that was added to avoid the seg-fault, other changes are made with my editor formatter (spaces and tabs stuff)

@heplesser
Copy link
Owner

@med-ayssar Thanks for your PR! I am not really happy with the formatting changes to do_tests.sh. Would you mind if I ported your changes to pynestkernel_api.pyx manually? I will credit you as co-author! And I will check with the original authors of the file about the two initialization functions.

@med-ayssar
Copy link
Author

med-ayssar commented Feb 11, 2025

Yeah, I don't mind. If you want, I can even revert the changes in the do_tests file.

@heplesser
Copy link
Owner

@med-ayssar Great if you could revert!

@med-ayssar
Copy link
Author

@heplesser, reverted!

Copy link
Owner

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@heplesser heplesser merged commit d17faa5 into heplesser:pynest-ng-adac Feb 11, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants