Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use zig 0.13.0 #85

Merged
merged 11 commits into from
Aug 18, 2024
Merged

build: use zig 0.13.0 #85

merged 11 commits into from
Aug 18, 2024

Conversation

hendriknielaender
Copy link
Owner

@hendriknielaender hendriknielaender commented Jun 11, 2024

  • update README.md
  • github action
  • use std.process.Child
  • build.zig lazyPath
  • new std.Progress api
  • added zon file

Closes #84

hendriknielaender and others added 3 commits June 11, 2024 19:04
Remove the term 'simple' from the README.md description of zbench, acknowledging that it no longer aligns with other one-file solutions in terms of simplicity.
@ivanstepanovftw
Copy link

And migration:

exe.addAnonymousModule("zbench", .{
  .source_file = .{ .path = "libs/zbench/zbench.zig" },
});

V

exe.root_module.addAnonymousImport("zbench", .{
  .root_source_file = b.path("libs/zbench/zbench.zig"),
});

@hendriknielaender
Copy link
Owner Author

@bens @FObersteiner does somebody have a smart idea to integrate the new progress api?

@FObersteiner
Copy link
Collaborator

FObersteiner commented Jul 27, 2024

@bens @FObersteiner does somebody have a smart idea to integrate the new progress api?

unfortunately I don't. Personally I haven't found a good use for this API, while at the same time it seems like a considerable amount of work to get into it. Andrew Kelley even wrote a blog post about it, but I wouldn't call this "user-facing documentation". Although, thread-safe, lock-free, and avoid contention sounds promising.

@hendriknielaender
Copy link
Owner Author

@FObersteiner I removed the old std.Progress, and leave the new progress api out of scope for this PR.

For the failing macOS platform test, I will have a look couldn't re-produce it on my machine.

@hendriknielaender hendriknielaender marked this pull request as ready for review August 17, 2024 21:00
@FObersteiner
Copy link
Collaborator

FObersteiner commented Aug 18, 2024

@FObersteiner I removed the old std.Progress, and leave the new progress api out of scope for this PR.

For the failing macOS platform test, I will have a look couldn't re-produce it on my machine.

added a zon file for convenient usage of the library in other projects.

doesn't fix the CI error ofc ^^ looks like it's coming from the platform info example. @hendriknielaender did you try to run it with a GPA instead of the fixed buffer allocator? Maybe this gives more helpful debug output.

@hendriknielaender
Copy link
Owner Author

@FObersteiner increased fixed buffer alloc to from 4096 to 8192 fixed the issue.
Maybe there is a smarter way to determine the fixed alloc for each platform.

@FObersteiner
Copy link
Collaborator

@FObersteiner increased fixed buffer alloc to from 4096 to 8192 fixed the issue. Maybe there is a smarter way to determine the fixed alloc for each platform.

right... nevertheless, even only 4k seems like overkill to parse an int

@hendriknielaender
Copy link
Owner Author

@FObersteiner increased fixed buffer alloc to from 4096 to 8192 fixed the issue. Maybe there is a smarter way to determine the fixed alloc for each platform.

right... nevertheless, even only 4k seems like overkill to parse an int

You are right, i created an issue to fix this even 4096 like you mentioned seems to overkill.
#88

@hendriknielaender hendriknielaender merged commit 463b546 into main Aug 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to Zig 0.13
3 participants