Code

Fix indexing inconsistencies#758

Code

Merged

coquelin77 merged 52 commits intomasterhelmholtz-analytics/heat:masterfrom bug/754-getitem-indexinghelmholtz-analytics/heat:bug/754-getitem-indexingCopy head branch name to clipboardJun 2, 2021

+349-162

Commits

Commits on Apr 13, 2021

• Fix getitem lshapes, split axes

  ClaudiaComito

  committed
  e898d87

  Copy full SHA for e898d87

• Fix tests

  ClaudiaComito

  committed
  2302795

  Copy full SHA for 2302795

Commits on Apr 14, 2021

• getitem lshapes, gshapes, local indices in non-split dimensions

  ClaudiaComito

  committed
  58bbb6a

  Copy full SHA for 58bbb6a

• Remove print statements

  ClaudiaComito

  committed
  54c8157

  Copy full SHA for 54c8157

• Adjust tests, slicing keeps split dimension

  ClaudiaComito

  committed
  641b2a2

  Copy full SHA for 641b2a2

• Always keep sliced dimension if key is slice()

  ClaudiaComito

  committed
  f238b95

  Copy full SHA for f238b95

• Remove dead code, rename advanced indexing bool

  ClaudiaComito

  committed
  f3db92f

  Copy full SHA for f3db92f

• Rework non-distributed case to return uniform results with distributed

  ClaudiaComito

  committed
  d6eeb48

  Copy full SHA for d6eeb48

• Merge branch 'bug/sort-balance' into bug/754-getitem-indexing

  ClaudiaComito

  committed
  f8efbcd

  Copy full SHA for f8efbcd

Commits on Apr 15, 2021

• Update changelog

  ClaudiaComito

  committed
  fccf633

  Copy full SHA for fccf633

Commits on Apr 20, 2021

• added ellipsis to get/set item functions

  coquelin77

  committed
  e557a16

  Copy full SHA for e557a16

Commits on Apr 28, 2021

• Lose split dimension if indexing 1 element and broadcast result. Implement DNDarray.counts_displs()

  ClaudiaComito

  committed
  6341c44

  Copy full SHA for 6341c44

• Update tests

  ClaudiaComito

  committed
  48e81a8

  Copy full SHA for 48e81a8

• create_lshape_map() to require communication only if DNDarray is not balanced

  ClaudiaComito

  committed
  f9a5820

  Copy full SHA for f9a5820

Commits on Apr 29, 2021

• Merge branch 'master' into bug/754-getitem-indexing

  coquelin77

  authored
  1886c1b

  Copy full SHA for 1886c1b

Commits on May 2, 2021

• Merge branch 'release/1.0.x' into bug/754-getitem-indexing

  ClaudiaComito

  committed
  3256f8f

  Copy full SHA for 3256f8f

• Simplify gout_full calculation via torch.as_strided()

  ClaudiaComito

  committed
  55c0ff3

  Copy full SHA for 55c0ff3

Commits on May 3, 2021

• Update tests

  ClaudiaComito

  committed
  f792cb3

  Copy full SHA for f792cb3

• Fix lshape_map for non-distributed case

  ClaudiaComito

  committed
  2e52e82

  Copy full SHA for 2e52e82

• Push .flake8 to repo

  ClaudiaComito

  committed
  9c07a76

  Copy full SHA for 9c07a76

• Merge branch 'bug/754-getitem-indexing' of github.com:helmholtz-analytics/heat into bug/754-getitem-indexing

  ClaudiaComito

  committed
  5721c32

  Copy full SHA for 5721c32

• Mandate shape (1,) for slice resulting in scalar DNDarray

  ClaudiaComito

  committed
  681d66b

  Copy full SHA for 681d66b

• Adjust tests

  ClaudiaComito

  committed
  b199593

  Copy full SHA for b199593

• Adapt advanced indexing to new gout_full assessment

  ClaudiaComito

  committed
  7d26831

  Copy full SHA for 7d26831

• Refine condition for slice.split=None

  ClaudiaComito

  committed
  575ff55

  Copy full SHA for 575ff55

Commits on May 5, 2021

• Make mixed-type key torch-compliant

  ClaudiaComito

  committed
  b2ca6c4

  Copy full SHA for b2ca6c4

• Fix seed broadcasting

  ClaudiaComito

  committed
  c2b13c6

  Copy full SHA for c2b13c6

• Debugging

  ClaudiaComito

  committed
  d5ebe3a

  Copy full SHA for d5ebe3a

Commits on May 6, 2021

• Remove single-item getitem loops

  ClaudiaComito

  committed
  ff7c4f2

  Copy full SHA for ff7c4f2

• Adapt tests to 1-element slicing

  ClaudiaComito

  committed
  026f7e0

  Copy full SHA for 026f7e0

• Address 1-d DNDarray key

  ClaudiaComito

  committed
  9de7a41

  Copy full SHA for 9de7a41

Commits on May 10, 2021

• Remove debugging code lines

  ClaudiaComito

  committed
  52a54b4

  Copy full SHA for 52a54b4

• Comment out broadcasting warnings

  ClaudiaComito

  committed
  6cd9a5f

  Copy full SHA for 6cd9a5f

Commits on May 11, 2021

• lshape of empty local tensor when empty dim is not the split axis

  ClaudiaComito

  committed
  7e9e040

  Copy full SHA for 7e9e040

• updated create_lshape_map() to account for constants

  coquelin77

  committed
  3e163e5

  Copy full SHA for 3e163e5

• updated docstring for lshape map to be clear about how the shapes are dealt with

  coquelin77

  committed
  813369d

  Copy full SHA for 813369d

• updated getitem to distributed constants for slices, ADVANCED INDEXING NOT CORRECTED YET

  coquelin77

  committed
  06f56ae

  Copy full SHA for 06f56ae

• corrected linalg.dot issue with different slicing, tests still failing

  coquelin77

  committed
  6fa6850

  Copy full SHA for 6fa6850

• added break away from bcast if the new split is not None, unsure if logic 100% correct

  coquelin77

  committed
  a1f0093

  Copy full SHA for a1f0093

Commits on May 12, 2021

• Adjust lshape for distributed advanced indexing.

  ClaudiaComito

  committed
  bb8515c

  Copy full SHA for bb8515c

• Revert "updated getitem to distributed constants for slices, ADVANCED INDEXING NOT CORRECTED YET"

  Show description for 5823db6
  coquelin77

  committed
  5823db6

  Copy full SHA for 5823db6

• Merge branch 'bug/754-getitem-indexing' of github.com:helmholtz-analytics/heat into bug/754-getitem-indexing

  ClaudiaComito

  committed
  2bf728c

  Copy full SHA for 2bf728c

• Restore create_lshape_map, GaussianNB changes incl. tests

  ClaudiaComito

  committed
  1da7401

  Copy full SHA for 1da7401

Commits on May 17, 2021

• Update counts_displs() documentation

  ClaudiaComito

  committed
  0c01850

  Copy full SHA for 0c01850

• counts_displs() documentation

  ClaudiaComito

  committed
  4249af0

  Copy full SHA for 4249af0

• Implement test_counts_displs()

  ClaudiaComito

  committed
  1d658dc

  Copy full SHA for 1d658dc

Commits on Jun 1, 2021

• Update CHANGELOG, remove dead code

  ClaudiaComito

  committed
  b9048ed

  Copy full SHA for b9048ed

• Merge branch 'master' into bug/754-getitem-indexing

  ClaudiaComito

  committed
  63df36e

  Copy full SHA for 63df36e

Commits on Jun 2, 2021

• Add reference to slice broadcasting issue (#784)

  ClaudiaComito

  committed
  bdd3ee2

  Copy full SHA for bdd3ee2

• Remove clone() experiment left in by mistake

  ClaudiaComito

  committed
  3cfc916

  Copy full SHA for 3cfc916

• added example to changelog breaking changes

  coquelin77

  committed
  030d99f

  Copy full SHA for 030d99f

• Merge branch 'bug/754-getitem-indexing' of https://github.com/helmholtz-analytics/heat into bug/754-getitem-indexing

  coquelin77

  committed
  cdf3e95

  Copy full SHA for cdf3e95