Skip to content

Conversation

@sergeynezbritskiy
Copy link

@sergeynezbritskiy sergeynezbritskiy commented Nov 12, 2025

This PR depends on a corresponding one in module-warranty helloextend/magento-extension#426

Summary by CodeRabbit

  • Bug Fixes
    • Fixed warranty offer validation to ensure accurate checking during order processing. Warranty offers will now be correctly identified and displayed in quotes.

@coderabbitai
Copy link

coderabbitai bot commented Nov 12, 2025

Walkthrough

A method parameter change was made to the isWarrantyInQuote() function call in the warranty-offers.phtml template file. Previously, the method accepted an item SKU string via $_item->getSku(). The call has been updated to pass an item ID as an integer via (int)$_item->getId() instead. Correspondingly, the isWarrantyInQuote() method signature was modified to expect an item ID integer parameter rather than a SKU string. The surrounding control flow and logic remain unchanged.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3a02011 and 8f2f501.

📒 Files selected for processing (1)
  • src/view/frontend/templates/order/item/warranty-offers.phtml (1 hunks)
🔇 Additional comments (1)
src/view/frontend/templates/order/item/warranty-offers.phtml (1)

36-36: Item ID parameter update looks good

Passing the order item ID keeps this template aligned with the new isWarrantyInQuote contract. Looks consistent with the surrounding usage.


Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant