Skip to content

Fix fatal error on line 427, as method hasWarranty expects product id instead of sku #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sergeynezbritskiy wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix fatal error on line 427, as method hasWarranty expects product id instead of sku #426

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63ebd01
Fix fatal error on line 427, as method hasWarranty expects product id…
sergeynezbritskiy Nov 12, 2025
d7dfa14
Rename the argument
sergeynezbritskiy Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ViewModel/Warranty.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,18 +413,18 @@ public function itemHasLeadWarrantyInQuote($orderItem): bool
* Check does quote have warranty item for the item
* Kept for backwards compatibility with Hyva module
*
* @param string $sku
* @param int $quoteItemId
* @return bool
*/
public function isWarrantyInQuote(string $sku): bool
public function isWarrantyInQuote(int $quoteItemId): bool
{
try {
$quote = $this->checkoutSession->getQuote();
} catch (LocalizedException $exception) {
$quote = null;
}
if ($quote) {
$hasWarranty = $this->hasWarranty($quote, $sku);
$hasWarranty = $this->hasWarranty($quote, $quoteItemId);
}
return $hasWarranty ?? false;
}
Expand Down