fix typecheck on build and cluster typing#4
Open
mooncitydev wants to merge 1 commit into
Open
Conversation
programLabel was using web3 Cluster while program metadata uses the app cluster enum, so typescript was fighting itself and the types did not match real usage. token balance fallback image now uses the public path instead of an import typescript could not resolve. dropped ignoreBuildErrors and ignoreDuringBuilds so ci and vercel actually surface problems.
Contributor
|
@mooncitydev is attempting to deploy a commit to the Helius Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hey, noticed
next.configwas set to ignore typescript and eslint during production builds, which means broken code could ship as long as webpack compiled. pulled those flags sonext buildactually runs the same checks you get in dev.also
programLabelimportedClusterfrom web3.js but the program map and call sites use the app cluster enum fromutils/cluster, so the types were incompatible and the explorer was in this weird split brain state. swapped the import to match.last thing, the token delta component imported an svg through a path typescript could not resolve on a clean checkout. using the public url for the placeholder logo avoids that and still works with the error fallback.