fix(examples): Correct zk getCompressedTokenAccountsByOwner example filename#332
Open
v-hawk-bot wants to merge 1 commit into
Open
fix(examples): Correct zk getCompressedTokenAccountsByOwner example filename#332v-hawk-bot wants to merge 1 commit into
v-hawk-bot wants to merge 1 commit into
Conversation
…ilename The example file was named getCompressedTokenAccountByOwner.ts (singular 'Account'), but its body calls helius.zk.getCompressedTokenAccountsByOwner (plural 'Accounts') — the actual exported SDK method. This was the only filename/method mismatch among the 26 zk examples; rename restores 1:1 naming parity with the rest of examples/zk/.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Renames
examples/zk/getCompressedTokenAccountByOwner.ts→examples/zk/getCompressedTokenAccountsByOwner.ts.Why
The example file was named
getCompressedTokenAccountByOwner.ts(singular "Account"), but its body callshelius.zk.getCompressedTokenAccountsByOwner(...)(plural "Accounts") — the actual exported SDK method (src/zk/methods/getCompressedTokenAccountsByOwner.ts).Every other
examples/zk/file matches its method name 1:1 (e.g.getCompressedTokenAccountsByDelegate.ts). This was the only filename/method mismatch among the 26 zk examples, so the rename restores naming parity and makes the example discoverable by its method name.Scope
*.ts/*.md/*.json).