Highlight a leaf #27
Open
Highlight a leaf #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helfi92
reviewed
Nov 13, 2018
Owner
helfi92
left a comment
helfi92
left a comment
There was a problem hiding this comment.
This would need a git rebase on master.
Contributor
Author
|
Somehow I didn't manage to rebase it to the master. I will go on on the weekend. |
Owner
|
You can try something similar to what is in taskcluster/taskcluster-web#231 (comment) (different repo but similar commands). |
Contributor
Author
|
That's basically what I tried. I probably got lost to the huge amount of conflicts. I followed these steps now and I hope I didn't miss conflict warnings somewhere. The git history is still a bit messed :/ |
Owner
|
The rebase seem to have worked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the PR #25
Allows to highlight a leaf by setting a custom class name to it. It only supports leafs and no parents.