Skip to content

Add raw data publishing setting.#874

Open
ShogunPanda wants to merge 2 commits into
heishamon:mainfrom
ShogunPanda:raw-setting
Open

Add raw data publishing setting.#874
ShogunPanda wants to merge 2 commits into
heishamon:mainfrom
ShogunPanda:raw-setting

Conversation

@ShogunPanda
Copy link
Copy Markdown

Hi!
This PR partially reverts the logic of b32bba8 by putting the raw data topic behind a runtime setting rather than a compile one.
This is useful when you want to get all settings at once via decoding the raw data.

Signed-off-by: Paolo Insogna <paolo@cowtech.it>
@IgorYbema
Copy link
Copy Markdown
Member

The part where it reads instead of writes to mqtt should then have a new setting also. Something like 'listen to raw data over mqtt'. Both settings should not be able to set at the same time.
Or the setting should be 'send data over mqtt' and then when user also selects 'listen only' it then changes to 'read data over mqtt' or something like that.
Without proper explaining to the user, the setting isn't clear enough. That is why I have it a compile flag for now

@ShogunPanda
Copy link
Copy Markdown
Author

@IgorYbema No worries, I can update this.
Do you mind giving me more context on the read via MQTT logic? What is that used for?

@IgorYbema
Copy link
Copy Markdown
Member

@IgorYbema No worries, I can update this. Do you mind giving me more context on the read via MQTT logic? What is that used for?

I use it in test cases. So have my production heishamon on my heatpump just publish the raw data and then have my test heishamon read it from mqtt. Then my test heishamon works as if it is connected to a heatpump also.

Signed-off-by: Paolo Insogna <paolo@cowtech.it>
@ShogunPanda
Copy link
Copy Markdown
Author

@IgorYbema I added a "listen to raw data" setting, mutually exclusive with the publishing one. How does it looks like now?

@IgorYbema
Copy link
Copy Markdown
Member

Look ok, however when selecting the listen to raw data it now uses the default 'panasonic_heat_pump' topic. Better would be that there is a new text field which then let the user define the other heishamon topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants