Fix: Remove orphaned legacyPrivacyCheck call causing TypeError in Contao 5 #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed orphaned call to this.legacyPrivacyCheck() from compiled JavaScript - The method was already removed from source code but compiled assets were outdated - This fixes the 'TypeError: this.legacyPrivacyCheck is not a function' error - Minimal surgical fix that only removes the problematic method call
- Also fixed the compiled assets in src/Resources/public/assets/ - Ensures compatibility across both branch structures - The method definition remains where it exists in source, only the problematic call is removed
Copilot
AI
changed the title
[WIP] Uncaught TypeError: this.legacyPrivacyCheck is not a function
Fix: Remove orphaned legacyPrivacyCheck call causing TypeError in Contao 5
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Users reported encountering
Uncaught TypeError: this.legacyPrivacyCheck is not a functionwhen trying to play videos with the bundle in Contao 5.3.27. This prevented videos from loading and privacy dialogs from appearing.Root Cause
The issue occurred because:
legacyPrivacyCheck()method was intentionally removed from the source code in the feature/contao_5 branch as part of legacy cleanupthis.legacyPrivacyCheck()from previous buildsSolution
Applied minimal surgical fixes to remove the orphaned method calls from compiled assets:
this.legacyPrivacyCheck(),callthis.legacyPrivacyCheck(),callVerification
✅ No
this.legacyPrivacyCheck()calls remain in any compiled assets✅ JavaScript syntax validation passed
✅ Minimal change scope (only 1-line changes to 2 asset files)
✅ Compatible with both master and feature/contao_5 branch structures
Impact
The fix ensures the video bundle works correctly in Contao 5.3.27 environments.
Fixes #25.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.