Skip to content

Conversation

@happy5214
Copy link
Member

Exactly what the title suggests.

@happy5214 happy5214 self-assigned this Dec 20, 2025
@qltysh
Copy link

qltysh bot commented Dec 20, 2025

Qlty

Coverage Impact

⬆️ Merging this pull request will increase total coverage on typescript by 1.72%.

Modified Files with Diff Coverage (14)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
src/schema/specs.ts91.7%186
Coverage rating: A Coverage rating: A
src/bids/types/json.ts100.0%
Coverage rating: A Coverage rating: A
src/parser/splitter.js100.0%
Coverage rating: B Coverage rating: A
src/parser/tokenizer.js100.0%
Coverage rating: B Coverage rating: A
src/parser/reservedChecker.js100.0%
Coverage rating: A Coverage rating: A
src/bids/datasetParser.ts100.0%
Coverage rating: B Coverage rating: B
src/bids/types/dataset.ts94.1%150
New file Coverage rating: F
src/utils/types.ts0.0%1-11
New file Coverage rating: A
src/parser/parsedHedGroup.ts98.8%171
New file Coverage rating: A
src/parser/parseUtils.ts98.1%42
New file Coverage rating: A
src/parser/parsedHedColumnSplice.ts100.0%
New file Coverage rating: A
src/parser/parsedHedSubstring.ts96.6%56-57
New file Coverage rating: A
src/parser/parsedHedTag.ts100.0%
New file Coverage rating: A
src/parser/parsedHedString.ts100.0%
Total95.3%
🤖 Increase coverage with AI coding...

In the `port-parsed-substrings` branch, add test coverage for this new code:

- `src/bids/types/dataset.ts` -- Line 150
- `src/parser/parseUtils.ts` -- Line 42
- `src/parser/parsedHedGroup.ts` -- Line 171
- `src/parser/parsedHedSubstring.ts` -- Line 56-57
- `src/schema/specs.ts` -- Line 186
- `src/utils/types.ts` -- Line 1-11

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@qltysh
Copy link

qltysh bot commented Dec 20, 2025

❌ 2 blocking issues (2 total)

Tool Category Rule Count
radarlint-js Lint Group parts of the regex together to make the intended operator precedence explicit. 1
radarlint-js Lint Type literal has only a call signature, you should use a function type instead. 1

Also make duplicate filter a generic function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants