fix(codex): skip sockets in session home overlay#2104
Merged
chopratejas merged 1 commit intoJul 13, 2026
Conversation
Contributor
PR governanceThis PR follows the template and is marked ready for human review. |
This was referenced Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevent
headroom wrap codexfrom failing when the activeCODEX_HOMEcontains a Unix socket. The session overlay copied every entry withshutil.copytree(), which raisesshutil.Errorwhen it reaches Git'sfsmonitor--daemon.ipcsocket.The overlay now skips socket entries while continuing to copy regular Codex state and surface unrelated copy errors.
Closes #2103
Type of Change
Changes Made
fsmonitor--daemon.ipcsocket and a regular sibling file.Testing
pytest tests/test_cli/test_wrap_codex.py -q)ruff check .)mypy headroom)Test Output
Real Behavior Proof
vendor_imports/skills/.git/fsmonitor--daemon.ipc, then enter_codex_session_home_overlay()through the focused pytest regression~/.codexReview Readiness
Checklist
Additional Notes
The filter is intentionally limited to socket entries. Permission errors and failures involving regular files still propagate from
shutil.copytree().