Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: bump to 7.6.0 #402

Closed
wants to merge 1 commit into from
Closed

Conversation

oharboe
Copy link

@oharboe oharboe commented Apr 4, 2025

Need to upgrade to be able to support MODULE.bazel

Signed-off-by: Øyvind Harboe <[email protected]>
@hzeller
Copy link
Collaborator

hzeller commented Apr 4, 2025

did you try if it works ? I think there are various bits and pieces that need to be addressed before it does.

@hzeller
Copy link
Collaborator

hzeller commented Apr 4, 2025

6.5.0 can also deal with MODULE.bazel if that is the issue.

@oharboe
Copy link
Author

oharboe commented Apr 4, 2025

did you try if it works ? I think there are various bits and pieces that need to be addressed before it does.

Trying a "bazel build ...", seems to work... Still running...

@oharboe
Copy link
Author

oharboe commented Apr 4, 2025

6.5.0 can also deal with MODULE.bazel if that is the issue.

Any reason to stay at 6 if we can go directly to 7.6.0?

@oharboe
Copy link
Author

oharboe commented Apr 4, 2025

did you try if it works ? I think there are various bits and pieces that need to be addressed before it does.

CI: Needs /gcbrun from a collaborator

@hzeller
Copy link
Collaborator

hzeller commented Apr 4, 2025

I think Ethan mentioned that it won't work with newer bazels yet.

@oharboe
Copy link
Author

oharboe commented Apr 4, 2025

6.5.0

I upgraded because 6.5.0 appears to ignore MODULE.bazel.

Hours of building can save me 5 minutes of reading the manual :-) https://bazel.build/external/migration#enable-bzlmod

$ cat MODULE.bazel 
aksjldaslkjfas

$ bazel query :*
//:BUILD
//:LICENSE
//:package_license
Loading: 0 packages loaded
$ cat .bazelversion 
6.5.0

@oharboe
Copy link
Author

oharboe commented Apr 4, 2025

This PR passes smoke-testing at least:

$ bazel build ...
[deleted]
[WARNING STA-1212] bazel-out/k8-fastbuild/bin/external/org_theopenroadproject_asap7sc7p5t_27/asap7-sc7p5t_rev27_rvt_4x-ccs_ss_SS.lib line 2858187, timing group from output port.
INFO: Found 901 targets...
INFO: Elapsed time: 1571.892s, Critical Path: 801.95s
INFO: 2053 processes: 1 internal, 2052 processwrapper-sandbox.
INFO: Build completed successfully, 2053 total actions

@hzeller
Copy link
Collaborator

hzeller commented Apr 4, 2025

@oharboe
Copy link
Author

oharboe commented Apr 4, 2025

bzlmod is disabled: https://github.com/hdl/bazel_rules_hdl/blob/main/.bazelrc#L14

Thanks! I'm catching up now.

@oharboe
Copy link
Author

oharboe commented Apr 4, 2025

I've become aware of the work that's being done here, so closing this issue.

@oharboe oharboe closed this Apr 4, 2025
@oharboe
Copy link
Author

oharboe commented Apr 4, 2025

#336 (comment)

@hzeller
Copy link
Collaborator

hzeller commented Apr 4, 2025

Note, there is a lot of work involved getting things to work with bzlmod here. I think it makes sense to rather focus on building a bzlmod directly than trying to get things going here.
(also context #336 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants