-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependency_support/pdk: add extract_lef_and_liberty targets #213
base: main
Are you sure you want to change the base?
Conversation
proppy
commented
Nov 8, 2023
•
edited
Loading
edited
- add sky130-fd_sc_hd_data targets
- add asap7-*_data targets
@mithro does this conflict with your effort to sync internal and external version? |
pdk/proto/BUILD
Outdated
deps = [":pdk_info_proto"], | ||
) | ||
|
||
extract_lef_and_liberty( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@QuantamHD not sure this is the best place for those?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not put these in the sk130 build file?
@QuantamHD - I've landed the changes which could have blocked @proppy, can you give this another look? |
You'll need to rebase this PR now, I landed part of this change in https://github.com/hdl/bazel_rules_hdl/pull/232/files |
8bc31a9
to
fc05476
Compare
rebased, PTAL |
/gcbrun |
@@ -22,3 +24,8 @@ licenses(["notice"]) | |||
exports_files([ | |||
"liberty_wrapper.py", | |||
]) | |||
|
|||
extract_lef_and_liberty( | |||
name = "sky130-fd_sc_hd_data", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to be consistent with asap7 (sky130-
instead of sky130_
) but this is a bit inconsistent with the cell library naming (sky130_
) let me know which one your prefer.
- add sky130-fd_sc_hd_data targets - add asap7-*_data targets
fc05476
to
ffdc90d
Compare
|