Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency_support/pdk: add extract_lef_and_liberty targets #213

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

proppy
Copy link
Collaborator

@proppy proppy commented Nov 8, 2023

  • add sky130-fd_sc_hd_data targets
  • add asap7-*_data targets

@proppy
Copy link
Collaborator Author

proppy commented Nov 8, 2023

@mithro does this conflict with your effort to sync internal and external version?

pdk/proto/BUILD Outdated
deps = [":pdk_info_proto"],
)

extract_lef_and_liberty(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@QuantamHD not sure this is the best place for those?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not put these in the sk130 build file?

@mithro
Copy link
Member

mithro commented Nov 16, 2023

@QuantamHD - I've landed the changes which could have blocked @proppy, can you give this another look?

@mithro
Copy link
Member

mithro commented Nov 21, 2023

You'll need to rebase this PR now, I landed part of this change in https://github.com/hdl/bazel_rules_hdl/pull/232/files

@proppy proppy changed the title pdk/proto: add package and targets dependency_support/pdk: add extract_lef_and_liberty targets Nov 22, 2023
@proppy
Copy link
Collaborator Author

proppy commented Nov 22, 2023

rebased, PTAL

@proppy
Copy link
Collaborator Author

proppy commented Nov 22, 2023

/gcbrun

@@ -22,3 +24,8 @@ licenses(["notice"])
exports_files([
"liberty_wrapper.py",
])

extract_lef_and_liberty(
name = "sky130-fd_sc_hd_data",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to be consistent with asap7 (sky130- instead of sky130_) but this is a bit inconsistent with the cell library naming (sky130_) let me know which one your prefer.

- add sky130-fd_sc_hd_data targets
- add asap7-*_data targets
@mithro
Copy link
Member

mithro commented Dec 19, 2023

Step #1: DEBUG: Repository scip instantiated at:
Step #1:   /workspace/WORKSPACE:150:19: in <toplevel>
Step #1:   /workspace/dependency_support/dependency_support.bzl:87:23: in dependency_support
Step #1:   /workspace/dependency_support/com_google_ortools/com_google_ortools.bzl:29:10: in com_google_ortools
Step #1:   /builder/home/.cache/bazel/_bazel_root/eab0d61a99b6696edb3d2aff87b585e8/external/bazel_tools/tools/build_defs/repo/utils.bzl:233:18: in maybe
Step #1: Repository rule new_git_repository defined at:
Step #1:   /builder/home/.cache/bazel/_bazel_root/eab0d61a99b6696edb3d2aff87b585e8/external/bazel_tools/tools/build_defs/repo/git.bzl:186:37: in <toplevel>
Step #1: Analyzing: 1093 targets (232 packages loaded, 88207 targets configured)
Step #1: Analyzing: 1093 targets (233 packages loaded, 88477 targets configured)
Step #1: ERROR: /workspace/dependency_support/org_theopenroadproject_asap7sc7p5t_28/BUILD:22:24: no such target '@org_theopenroadproject_asap7sc6t_26//:asap7-sc7p5t_rev28_lvt': target 'asap7-sc7p5t_rev28_lvt' not declared in package '' (did you mean 'asap7-sc6t_rev26_lvt'?) defined by /builder/home/.cache/bazel/_bazel_root/eab0d61a99b6696edb3d2aff87b585e8/external/org_theopenroadproject_asap7sc6t_26/BUILD.bazel and referenced by '//dependency_support/org_theopenroadproject_asap7sc7p5t_28:asap7-sc7p5t_rev28_lvt_data'
Step #1: ERROR: Analysis of target '//dependency_support/org_theopenroadproject_asap7sc7p5t_28:asap7-sc7p5t_rev28_lvt_data' failed; build aborted: Analysis failed
Step #1: INFO: Elapsed time: 372.320s
Step #1: INFO: 0 processes.
Step #1: FAILED: Build did NOT complete successfully (234 packages loaded, 88667 targets configured)
Step #1: FAILED: Build did NOT complete successfully (234 packages loaded, 88667 targets configured)
Step #1: INFO: Streaming build results to: https://app.buildbuddy.io/invocation/043c9e96-9e24-11ee-a6ff-0242c0a80a02
Step #1: FAILED: Build did NOT complete successfully (234 packages loaded, 88667 targets configured)
Step #1: bazel build --build_metadata=USER=proppy     --config=ciremotebuild     --bes_results_url=https://app.buildbuddy.io/invocation/ --invocation_id=043c9e96-9e24-11ee-a6ff-0242c0a80a02 //... @at_clifford_icestorm//... @at_clifford_yosys//... @com_github_westes_flex//... @com_github_fmtlib_fmt//... @com_github_gabime_spdlog//... @com_github_libbacktrace//... @com_github_ninja_build_ninja//... @com_github_quantamhd_lemon//... @com_github_yosyshq_nextpnr//... @com_github_yosyshq_prjtrellis//... @com_github_yosyshq_prjtrellis_db//... @com_google_skywater_pdk//... @com_google_skywater_pdk_sky130_fd_sc_ms//... @com_google_skywater_pdk_sky130_fd_sc_ls//... @com_google_skywater_pdk_sky130_fd_sc_lp//... @com_google_skywater_pdk_sky130_fd_sc_hvl//... @com_google_skywater_pdk_sky130_fd_sc_hs//... @com_google_skywater_pdk_sky130_fd_sc_hdll//... @com_google_skywater_pdk_sky130_fd_sc_hd//... @com_google_skywater_pdk_sky130_fd_pr//... @com_google_skywater_pdk_sky130_fd_io//... @com_icarus_iverilog//... @com_opencircuitdesign_magic//... @com_opencircuitdesign_netgen//... @edu_berkeley_abc//... @net_sourceforge_ngspice//... @net_zlib//... @org_fftw//... @org_gnu_bison//... @org_gnu_glpk//... @org_gnu_gperf//... @org_gnu_m4//... @org_gnu_readline//... @org_llvm_openmp//... @org_pcre_ftp//... @org_nixos_patchelf//... @org_sourceware_bzip2//... @org_sourceware_libffi//... @org_swig//... @org_theopenroadproject_asap7_pdk_r1p7//... @org_theopenroadproject_asap7sc7p5t_28//... @pybind11//... @rules_pkg//... @tk_tcl//...
Finished Step #1
ERROR
ERROR: build step 1 "gcr.io/cloud-builders/bazel" failed: step exited with non-zero status: 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants