Fix ASAP7 for reworked upstream repo structure. #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
mithro
force-pushed
the
temp-fix-asap7
branch
from
bc4bc4e to
ca1e78a
Compare
QuantamHD
approved these changes
Nov 7, 2023
proppy
reviewed
Nov 9, 2023
| sha256 = "fd9e99f6ccb9e946755f9bc444abefbdd1eedb32c372c56dcacc7eb486aed178", | ||
| ) | ||
|
|
||
| load("@rules_7zip//:setup.bzl", "setup_7zip") |
There was a problem hiding this comment.
maybe this should go into dependency support instead? so that downstream of this package don't have to do the same thing in their workspace?
There was a problem hiding this comment.
I don't understand bazel enough to know when something should go into dependency_support verse WORKSPACE. @QuantamHD - Do you have any guidance?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.