[HZG-381] Mutable interceptor #1704
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for hardcore-allen-f5257d ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Rob-Hazelcast
approved these changes
May 19, 2025
JamesHazelcast
approved these changes
May 19, 2025
JamesHazelcast
added
the
backport to all versions
ahmetmircik
reviewed
May 20, 2025
| @@ -247,6 +247,8 @@ Map interceptors are chained, so adding the same interceptor to the same map mor | |||
| When you add the interceptor in this way, be sure to implement the `hashCode()` method to return the same value for every instance of the interceptor. | |||
| It is not strictly necessary, but it is a good idea to also implement `equals()` as this ensures that the map interceptor can be removed reliably. | |||
|
|
|||
| Input values in interceptors are mutable, which means that if you modify the input value in one interceptor, the next interceptor in the chain will receive the updated value. This will also affect any subsequent processing. It's therefore best to avoid modifying the input value directly. | |||
There was a problem hiding this comment.
Can we also include the reason why we are keeping it mutable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added information that the input arguments of the interceptor are mutable.