Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strong api string localizers generator using incremental generator #994

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

jirikanda
Copy link
Contributor

  • No longer generates marker classes (no garbage in IntelliSense 💪).
  • No longer uses DelegatingStringLocalizer (Havit.Extensions.Localization now serves no purpose).
  • Generates neutral value comments in the code.
  • No longer searches for or uses the ResourceServiceCollectionInstaller partial class (the generator now produces its own static class).
  • Includes a unit test.
  • Localizers no longer implement IStringLocalizer<>, they implement only IStringLocalizer (therefore, no marker class is needed).
  • Generators cannot detect RESX files unless explicitly mentioned in the .csproj file.
  • Generates a warning when no RESX file is found, including a hint on how to modify the .csproj file (can check if this can be implemented using a code fix).
  • Uses a clone of HttpUtilityExt for human-readable, culture-specific character HTML encoding (e.g., "á" remains "á" and is not converted to an HTML entity).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant