Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HxMultiSelect] Adds Floating Label type to MultiSelect component #899

Merged

Conversation

mmonteagudo
Copy link
Contributor

This intends to add Floating Label type to the Multiselect component

@mmonteagudo
Copy link
Contributor Author

This solves issue #900

@hakenr hakenr linked an issue Oct 5, 2024 that may be closed by this pull request
Copy link
Member

@hakenr hakenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmonteagudo There are a few points to polish. Please let me know if you want to resolve them or if you prefer us to finish the PR.

@crdo Please check the PR from your POV.

@hakenr hakenr self-assigned this Nov 7, 2024
@hakenr hakenr added the Premium label Nov 18, 2024
Copy link
Member

@hakenr hakenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your contribution! I've consolidated the PR (check out the commits if you're interested), and it's now ready to be merged.

@hakenr hakenr merged commit 0c99e76 into havit:master Nov 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HxMultiSelect] Floating label support
2 participants