Specify source in config #172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahmoud
approved these changes
Sep 8, 2020
There was a problem hiding this comment.
Looks good, should help with local testing. Note that the Toolforge utility API used for testing is down sometimes, I usually log in and give it a restart and it runs for a few more months. Also, sometimes the schema changes out from under it, in which case we fix the code and redeploy :)
|
|
||
| config = load_env_config() | ||
|
|
||
| config_source = config.get('source') |
There was a problem hiding this comment.
source is a little vague here, can we call it commons_source?
An aside: remote and local are pretty bad names, too, I'll take the full blame. The proper meaning, maybe worth a comment: remote = toolforge util service (ideal name: tools_api), local = toolforge commons db replica (ideal name: db_replica).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to use fair Commons database in development environment by config file option (BTW I have not managed to use "remote" source last time I tried).