-
Notifications
You must be signed in to change notification settings - Fork 455
feat(engine): terminal status-based idempotency key release #4460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 16 commits
1d9909d
785717e
3ac5746
63496ef
64582a5
4c9f96e
ee44c1b
2ed1afb
3f51ad4
eb265ae
08c6ffe
91e2d6d
e28ad8a
db544b9
68b4c1d
f879bcb
3181863
ffab288
339664b
39b694d
2cdcb98
05ab6b9
1ffdc09
0bf5f6f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| -- +goose Up | ||
| -- +goose StatementBegin | ||
| CREATE TYPE idempotency_method AS ENUM ('TTL', 'STATUS'); | ||
|
|
||
| ALTER TABLE "WorkflowVersion" | ||
| ADD COLUMN "idempotencyMethod" idempotency_method; | ||
| -- +goose StatementEnd | ||
|
|
||
| -- +goose Down | ||
| -- +goose StatementBegin | ||
| DROP TYPE idempotency_method; | ||
| ALTER TABLE "WorkflowVersion" | ||
| DROP COLUMN "idempotencyMethod"; | ||
| -- +goose StatementEnd | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we add a
DEFAULTto make this easier on ourselves, so we don't need to deal with the null values?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, since then we'd have most rows with an idempotency method but no expression or ttl - it's probably "correct" to make the idempotency config a separate table instead and then have these all be non-null, but I don't really want to deal with adding joins all over. How strongly do you feel...?