Skip to content

chore: show appropriate message for hatchet server start --disable-auth#4397

Merged
mnafees merged 1 commit into
mainfrom
nafees/disable-auth-msg
Jul 15, 2026
Merged

chore: show appropriate message for hatchet server start --disable-auth#4397
mnafees merged 1 commit into
mainfrom
nafees/disable-auth-msg

Conversation

@mnafees

@mnafees mnafees commented Jul 10, 2026

Copy link
Copy Markdown
Member

Description

When launching an auth disabled local server from the CLI we should print the embedded token and an appropriate message about auth being disabled.

Type of change

  • Chore (changes which are not directly related to any business logic)

Checklist

Changes have been:

  • Tested (unit, integration, or manually with steps specified)
  • Linted and formatted

🤖 AI Disclosure
  • I acknowledge that an LLM was used in the creation of this Pull Request, in accordance with Hatchet's AI_POLICY.md.
  • Details: [e.g. generating tests, writing docs]

@mnafees
mnafees requested review from abelanger5 and Copilot July 10, 2026 12:22
@mnafees mnafees self-assigned this Jul 10, 2026
@vercel

vercel Bot commented Jul 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hatchet-docs Ready Ready Preview, Comment Jul 10, 2026 12:23pm

Request Review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Hatchet CLI’s local server startup messaging to better reflect the hatchet server start --disable-auth behavior by showing an auth-disabled notice and printing the generated API token for worker/client usage.

Changes:

  • Extends serverStartedView to accept a disableAuth flag and conditionally show either admin credentials or an auth-disabled message.
  • Prints the generated API token to stdout when --disable-auth is enabled.
  • Updates the worker setup flow to match the updated serverStartedView signature.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
cmd/hatchet-cli/cli/worker.go Updates the serverStartedView call to include the new disableAuth parameter.
cmd/hatchet-cli/cli/server.go Adds --disable-auth-aware startup messaging and prints the token when auth is disabled; updates serverStartedView signature/behavior.

Comment thread cmd/hatchet-cli/cli/server.go
Comment thread cmd/hatchet-cli/cli/worker.go
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Optional test failure: The load-deadlock job failed on this PR (optimistic-scheduling=false). This check is non-mandatory and does not block merging, but may be worth investigating. View logs

@mnafees
mnafees merged commit aad903d into main Jul 15, 2026
39 of 40 checks passed
@mnafees
mnafees deleted the nafees/disable-auth-msg branch July 15, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine Related to the core Hatchet engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants