Skip to content

fix: invert shouldRefill() condition in v1 scheduler rate limiter #4379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CoderSufiyan wants to merge 2 commits into
base: main
Choose a base branch
from
+67 −1
Open

fix: invert shouldRefill() condition in v1 scheduler rate limiter #4379

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97ab31b
fix: invert shouldRefill() condition in v1 scheduler rate limiter
CoderSufiyan Jul 8, 2026
ae8515a
test: add unit tests for shouldRefill() and expired-window refresh
CoderSufiyan Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/scheduling/v1/rate_limit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ func (r *rateLimiter) shouldRefill() bool {
return false
}

return r.nextRefillAt.After(time.Now().UTC())
return !r.nextRefillAt.After(time.Now().UTC())
}

func (r *rateLimiter) copyDbRateLimits() rateLimitSet {
Expand Down