feat: local auth disabled mode and dev images#4325
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
|
|
|
|
|
|
|
|
|
|
mrkaye97
left a comment
There was a problem hiding this comment.
I left some small comments, but generally this looks good.
One thing I'm a bit nervous about is polluting the frontend with more conditional rendering based on this state, but I'm not sure of other ways around it, unfortunately
| } | ||
|
|
||
| func (a *AuthZ) authorizeTenantOperations(tenantMemberRole sqlcv1.TenantMemberRole, r *middleware.RouteInfo) error { | ||
| func (a *AuthZ) authorizeTenantOperations(roleName string, r *middleware.RouteInfo) error { |
There was a problem hiding this comment.
what's the reason for this change?
There was a problem hiding this comment.
we now have an internal-only NOAUTH role which does not conform to a sqlcv1.TenantMemberRole anymore
| configLoader := loader.NewConfigLoader(configDirectory) | ||
|
|
||
| cleanup, server, err := configLoader.CreateServerFromConfig("", func(scf *server.ServerConfigFile) { | ||
| cleanup, srv, err := configLoader.CreateServerFromConfig("", func(scf *server.ServerConfigFile) { |
There was a problem hiding this comment.
nit, but do we need this naming change? imo, server is more clear than srv
There was a problem hiding this comment.
so I chose to do this since the package name is also server and it was confusing me while I was revisiting this code 😅
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Description
Introduces the local auth disabled mode. Partially fulfills #3680.
Type of change
What's Changed
-devprefixed images--disable-authflag tohatchet server startChecklist
Changes have been:
🤖 AI Disclosure