Skip to content

fix(sdks/ts): don't crash on Node watch-mode messages #4284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
princed wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(sdks/ts): don't crash on Node watch-mode messages #4284

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7f9b5c
Fix heartbeat worker watch-mode messages
princed Jun 26, 2026
be11b35
Remove AI-generated tests lol
princed Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions sdks/typescript/src/clients/dispatcher/heartbeat/heartbeat-controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,17 @@ import path from 'path';
import { runThreaded } from '@hatchet/util/thread-helper';
import { ClientConfig } from '../../hatchet-client';
import { DispatcherClient } from '../dispatcher-client';
import { z } from 'zod/v4';

export interface HeartbeatMessage {
type: 'info' | 'warn' | 'error' | 'debug';
message: string;
}
const HeartbeatMessageSchema = z.object({
type: z.enum(['info', 'warn', 'error', 'debug']),
message: z.string(),
});

export type HeartbeatMessage = z.infer<typeof HeartbeatMessageSchema>;

export const isHeartbeatMessage = (message: unknown): message is HeartbeatMessage =>
HeartbeatMessageSchema.safeParse(message).success;

export const STOP_HEARTBEAT = 'stop';
export class Heartbeat {
Expand Down Expand Up @@ -41,7 +47,11 @@ export class Heartbeat {
},
});

this.heartbeatWorker.on('message', (message: HeartbeatMessage) => {
this.heartbeatWorker.on('message', (message: unknown) => {
if (!isHeartbeatMessage(message)) {
return;
}

this.logger[message.type](message.message);
});
}
Expand Down
Loading