Skip to content

Make litName an untyped TH expression splice for now #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jberryman wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Make litName an untyped TH expression splice for now #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Language/GraphQL/Draft/Syntax.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ import {-# SOURCE #-} Language.GraphQL.Draft.Parser
)
import {-# SOURCE #-} Language.GraphQL.Draft.Printer (renderExecutableDoc)
import Language.GraphQL.Draft.Syntax.Internal (liftTypedHashMap)
import Language.Haskell.TH.Syntax (Lift, Q, TExp)
import Language.Haskell.TH.Syntax (Lift, Q, Exp)
import Language.Haskell.TH.Syntax qualified as TH
import Prettyprinter (Pretty (..))
import Prelude
Expand Down Expand Up @@ -129,8 +129,8 @@ parseName text = maybe (fail errorMessage) pure $ mkName text
where
errorMessage = T.unpack text <> " is not valid GraphQL name"

litName :: Text -> Q (TExp Name)
litName = parseName >=> \name -> [||name||]
litName :: Text -> Q Exp -- (TExp Name)
litName = parseName >=> \name -> [|name|]

instance J.FromJSON Name where
parseJSON = J.withText "Name" parseName
Expand Down