Skip to content

Add instances for :+: and :*: #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Ericson2314
Copy link
Contributor

@Ericson2314 Ericson2314 commented Apr 8, 2022

It could be a superclass of GEq, but this would be a breaking change
and interferes with Safe Haskell, so we refrained from making it one.

(Continuing #21.)

@Ericson2314 Ericson2314 force-pushed the jhartzell42/more-geq-gcompare-instances branch from 2b27872 to 6f292f1 Compare April 9, 2022 16:04
@Ericson2314 Ericson2314 changed the title Add GEq and GCompare instances for :+: and :*: Add instances for :+: and :*: Apr 9, 2022
@Ericson2314 Ericson2314 force-pushed the jhartzell42/more-geq-gcompare-instances branch from 6f292f1 to c102507 Compare April 9, 2022 18:01
@jhartzell42
Copy link
Contributor

Did I accidentally delete the branch on this?

@Ericson2314
Copy link
Contributor Author

@jhartzell42 I just couldn't push to it.

@Ericson2314
Copy link
Contributor Author

@phadej Please review this.

@Ericson2314 Ericson2314 force-pushed the jhartzell42/more-geq-gcompare-instances branch from c102507 to 0b48551 Compare May 18, 2022 13:57
@phadej
Copy link
Collaborator

phadej commented Jun 17, 2022

Amdended and merged in #48 and released https://hackage.haskell.org/package/some-1.0.4

@phadej phadej closed this Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants