Re-enabling Cabal-3.12 #493
Conversation
There was a problem hiding this comment.
Extending version range of cabal dependency makes sense to me.
Could you please make sure hls can be built with these looser constraints (e.g. using source-repository-package referring to this PR's commit in hls repo similar to how this PR does it?
GuillaumedeVolpiano
force-pushed
the
ghc9.10
branch
2 times, most recently
from
02bbaea to
84684c4
Compare
Note that the tests will only work on ghc-9.10 because we have another issue : there is no hlint version compatible with ghc-lib-parser-9.10 (they went directly from 9.8 to 9.12) |
|
@jhrcek : tests pass on ghc-9.10 |
There was a problem hiding this comment.
Great news 🙂 @jaspervdj could you please release 0.15.0.1 with these changes? We seem to need these relaxed version bound to be able to enable stylish in hls for ghc 9.10
GuillaumedeVolpiano
force-pushed
the
ghc9.10
branch
from
6c32cce to
5fc24e9
Compare
|
The changes are also working for Cabal 3.10, so I relaxed the testing conditions, this way we still support ghc-9.6 and ghc-9.8 |
GuillaumedeVolpiano
force-pushed
the
ghc9.10
branch
from
5fc24e9 to
b22234c
Compare
|
OK, so we have another issue with ghc-9.6.7, linked to this . I'm trying to track it down, hopefully it's here and not in ghc-lib-parser |
GuillaumedeVolpiano
force-pushed
the
ghc9.10
branch
2 times, most recently
from
f7b060e to
7e9e95d
Compare
|
So the issue with ghc-9.6.7 is with ghc-lib-parser. Reported here digital-asset/ghc-lib#595 |
|
For what it's worth, there is the same issue with ghc-lib-parser-9.12.2 and ghc-9.8.4. The folks over at #ghc said to downgrade to ghc-lib-parser-9.8.5 (for ghc-9.6.7). I'm going to disable ghc-9.6 from the tests for now. If we want to include ghc 9.6 support, we are going to need to wait for a potential update of ghc-lib-parser-9.10. Oh, and in case you're wondering : there was no issue until yesterday because apparently Ubuntu just pushed ghc-9.6.7. Update: the issue is actually fixed in the live version of ghc-lib-parser ( digital-asset/ghc-lib@d4e1bc6#diff-472eaebd24c7e540a4d552d3b13cab6de8eb8d327990ae09778d91f30ae430f1 ). So either we wait for a new release, or we just ditch 9.6 for now. |
GuillaumedeVolpiano
force-pushed
the
ghc9.10
branch
from
7e9e95d to
bf2d747
Compare
|
Maybe no need to exclude 9.6. from CI altogether - you could just "pin" the previous patch version by specifying "9.6.6" in CI config (+ add a short comment linking the issue with 9.6.7 so it's clear in the future why more specific version is used)? I'm not sure about this, I haven't looked at upstream issues, so feel free to ignore this comment for now. |
GuillaumedeVolpiano
force-pushed
the
ghc9.10
branch
from
5879b4b to
f7d5cd9
Compare
|
Well, I'll follow @jaspervdj and your lead on when is the best time to release. I've followed your advice and re-enabled 9.6.6 in the ci, with a note. Tests passed on my fork. My 2 pence: we don't know if and when a new version of ghc-lib-parser-9.10 will be released, and there is no other reason the tests should fail on ghc-9.6.7. Also, we need this Cabal backport if we want to be able to use the ghc-lib-parser-9.12 version with <=ghc-9.10 (where we'll encounter the same issue with ghc-9.8.4 vs 9.8.3 for now, I think). As this is a fix, I think we could release, but once again, not my call on either side of the stream ;) |
|
Thanks! I am pushing one commit here to minimize the diff. Then I'll release these changes, and after that I'll work on releasing #491. |
|
Released in |
@jaspervdj : the bump to Cabal-3.14 creates an issue downstream with haskell-language-server, where many ghc-9.10 plugins are hard limited to Cabal-3.12. This patch attempts to adress the situation.
@jhrcek : I think this respects the logic behind your changes.