Fix #96 Write files with utf8 encoding, not, effectively, char8 #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI fails with GHC 8.2.2. However: (a) I think that is for reasons unrelated to this pull request and (b) GHC 8.2.2, released on 22 July 2017, is considered obsolete by the Cabal and Stack projects. |
|
The CI for Linux/GHC 9.12.20241014 is failing for reasons unrelated to this pull request. |
|
I have not investigated what the current CI actually tests but, having identified the original GHC issue https://gitlab.haskell.org/ghc/ghc/-/issues/3837, I tested on Windows 11 with the given -- エand that still worked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on my experiments on Windows, issue:
can be fixed by writing files with UTF8 encoding, instead of, effectively,
char8.