Skip to content

Refactor HTML / attribute handling with prefixes #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmjio wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor HTML / attribute handling with prefixes #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/Miso/From/Html.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
-----------------------------------------------------------------------------
module Miso.From.Html where
-----------------------------------------------------------------------------
import Data.Char
import Control.Monad (guard)
import Control.Monad.State
import Control.Applicative
import Data.Char
import Data.List hiding (takeWhile)
import Data.Map (Map)
import qualified Data.Map as M
Expand Down Expand Up @@ -55,7 +55,8 @@ instance Show HTML where
show (TextNode x) = "\"" <> T.unpack x <> "\""
show (Node isOpen t as cs) =
mconcat $
[ T.unpack t
[ "H."
, T.unpack t
, "_ "
, show as
] ++
Expand Down Expand Up @@ -84,7 +85,7 @@ instance Show HTMLAttr where
| "data-" `T.isPrefixOf` k
, Just rest <- T.stripPrefix "data-" k =
mconcat
[ " data_ \""
[ " P.data_ \""
, T.unpack rest
, "\""
, " \""
Expand All @@ -94,7 +95,7 @@ instance Show HTMLAttr where
| "aria-" `T.isPrefixOf` k
, Just rest <- T.stripPrefix "aria-" k =
mconcat
[ " aria_ \""
[ " P.aria_ \""
, T.unpack rest
, "\""
, " \""
Expand All @@ -112,7 +113,7 @@ instance Show HTMLAttr where
]
| otherwise =
mconcat
[ " "
[ " P."
, T.unpack k
, "_ "
, "\""
Expand All @@ -121,10 +122,10 @@ instance Show HTMLAttr where
]
show (HTMLAttr x@(T.isPrefixOf "data-" -> True) Nothing) =
case T.stripPrefix "data-" x of
Just rest -> "data_ " <> "\"" <> T.unpack rest <> "\"" <> " \"\""
Just rest -> "P.data_ " <> "\"" <> T.unpack rest <> "\"" <> " \"\""
Nothing -> T.unpack x
show (HTMLAttr "checked" Nothing) =
"checked_ True"
"P.checked_ True"
show (HTMLAttr k Nothing) =
mconcat
[ "textProp \""
Expand Down