Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

記事の追加: リベンジ・オブ・毎時更新 Haskell Antenna #183

Merged

Conversation

matsubara0507
Copy link
Member

haskell-jp/antenna#19 で取り組んでる奴を記事にします。
1回ぐらい更新されるのを確認したらドラフトを外します。

@matsubara0507 matsubara0507 self-assigned this Jan 17, 2020
@matsubara0507 matsubara0507 marked this pull request as ready for review January 18, 2020 13:09
@matsubara0507
Copy link
Member Author

無事一回成功した

Copy link
Member

@igrep igrep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

細かいところだけ指摘しておきました!

[2019年の今頃、これを自動毎時更新しようと Drone Cloudによる毎時更新を設定しました](https://haskell.jp/blog/posts/2019/hourly-antenna.html)。

しかし。。。なんと3月ぐらいからこれが止まっています(どうやら、[Drone Cloudのこの機能を利用してマイニングをした人がいたらしく止めてしまった](https://discourse.drone.io/t/cron-on-cloud-drone-io/3899/2)ようです)。
現在は**僕がだいたい毎朝1回、手動でCIを回しています**。。。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

知らんかったww

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

私も回してました 😏

Copy link
Member

@igrep igrep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すみません、もう一カ所気になるところがあった! 🙏

## git コマンドを呼ぶ

Haskellアプリケーションからgitコマンドを実行するには[Shelly](https://hackage.haskell.org/package/shelly)を使うことにします。
Shellyはmix.hsのshellプラグインを使うことで簡単に実装することができます。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

「簡単に実装することができます」じゃなくて「簡単に使用することができます」かな?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦀

Copy link
Member

@igrep igrep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いいと思います!素晴らしい!松原君のタイミングで公開してください!
d38e23ec

@matsubara0507
Copy link
Member Author

レビューありがとうございます!

@matsubara0507 matsubara0507 merged commit bb4c0e9 into haskell-jp:master Jan 19, 2020
@matsubara0507 matsubara0507 deleted the revenge-of-hourly-antenna branch January 19, 2020 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants