Skip to content

Log unhandled exceptions #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# log-effectful-1.2.0.0 (2025-06-23)
* Log any uncaught exception

# log-effectful-1.0.1.0 (2024-11-07)
* Convert `Log` into a dynamically dispatched effect.

Expand Down
4 changes: 3 additions & 1 deletion log-effectful.cabal
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
cabal-version: 3.0
build-type: Simple
name: log-effectful
version: 1.0.1.0
version: 1.2.0.0
license: BSD-3-Clause
license-file: LICENSE
category: System
Expand Down Expand Up @@ -41,6 +41,7 @@ common language
LambdaCase
MultiParamTypeClasses
NoStarIsType
OverloadedStrings
RankNTypes
RoleAnnotations
ScopedTypeVariables
Expand All @@ -56,6 +57,7 @@ library
build-depends: base <5
, aeson >=2.0.0.0
, effectful-core >=1.0.0.0 && <3.0.0.0
, lifted-base
, log-base >=0.12.0.0
, text
, time
Expand Down
32 changes: 20 additions & 12 deletions src/Effectful/Log.hs
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import Data.Aeson.Types
import Data.Text (Text)
import Data.Time.Clock
import Effectful.Dispatch.Dynamic
import Effectful.Exception
import Effectful.Reader.Static
import Effectful
import Log
Expand Down Expand Up @@ -44,18 +45,8 @@ runLog
-> Eff (Log : es) a
-- ^ The computation to run.
-> Eff es a
runLog component logger maxLogLevel = reinterpret reader $ \env -> \case
LogMessageOp level message data_ -> do
time <- liftIO getCurrentTime
logEnv <- ask
liftIO $ logMessageIO logEnv time level message data_
LocalData data_ action -> localSeqUnlift env $ \unlift -> do
(`local` unlift action) $ \logEnv -> logEnv { leData = data_ ++ leData logEnv }
LocalDomain domain action -> localSeqUnlift env $ \unlift -> do
(`local` unlift action) $ \logEnv -> logEnv { leDomain = leDomain logEnv ++ [domain] }
LocalMaxLogLevel level action -> localSeqUnlift env $ \unlift -> do
(`local` unlift action) $ \logEnv -> logEnv { leMaxLogLevel = level }
GetLoggerEnv -> ask
runLog component logger maxLogLevel =
reinterpret reader effectHandler . handle logException
where
reader = runReader LoggerEnv
{ leLogger = logger
Expand All @@ -64,6 +55,23 @@ runLog component logger maxLogLevel = reinterpret reader $ \env -> \case
, leData = []
, leMaxLogLevel = maxLogLevel
}
effectHandler :: (IOE :> handlerEs, Reader LoggerEnv :> handlerEs) => EffectHandler Log handlerEs
effectHandler env = \case
LogMessageOp level message data_ -> do
time <- liftIO getCurrentTime
logEnv <- ask
liftIO $ logMessageIO logEnv time level message data_
LocalData data_ action -> localSeqUnlift env $ \unlift -> do
(`local` unlift action) $ \logEnv -> logEnv { leData = data_ ++ leData logEnv }
LocalDomain domain action -> localSeqUnlift env $ \unlift -> do
(`local` unlift action) $ \logEnv -> logEnv { leDomain = leDomain logEnv ++ [domain] }
LocalMaxLogLevel level action -> localSeqUnlift env $ \unlift -> do
(`local` unlift action) $ \logEnv -> logEnv { leMaxLogLevel = level }
GetLoggerEnv -> ask
logException :: (IOE :> es, Log :> es) => SomeException -> Eff es a
logException (SomeException e) = do
logAttention "Uncaught exception" $ object ["error" .= show e]
throwIO e

-- | Orphan, canonical instance.
instance Log :> es => MonadLog (Eff es) where
Expand Down