Skip to content

add utc callout to rotation fields #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

add utc callout to rotation fields #1075

wants to merge 8 commits into from

Conversation

kpcraig
Copy link
Contributor

@kpcraig kpcraig commented Oct 8, 2025 •
edited
Loading

@kpcraig kpcraig requested a review from a team as a code owner October 8, 2025 17:33
@github-actions github-actions bot added the Vault Content update for Vault product docs label Oct 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025 •
edited
Loading

Vercel Previews Deployed

Name Status Preview Updated (UTC)
Dev Portal ✅ Ready (Inspect) Visit Preview Wed Oct 15 16:14:30 UTC 2025
Unified Docs API ✅ Ready (Inspect) Visit Preview Wed Oct 15 16:08:38 UTC 2025

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025 •
edited
Loading

Broken Link Checker

No broken links found! 🎉

@github-actions github-actions bot added the Vault IC Higher priority Vault content PR. Update relates to an important changes announcement. label Oct 8, 2025
@kpcraig
Copy link
Contributor Author

kpcraig commented Oct 9, 2025

The anticipation is that this is also going to get backported to 1.20 and 1.19 - is the proper way to do that to open a PR for those folders on main, or should I add them here?

@schavis
Copy link
Contributor

schavis commented Oct 9, 2025

The anticipation is that this is also going to get backported to 1.20 and 1.19 - is the proper way to do that to open a PR for those folders on main, or should I add them here?

We have a content freeze in place atm because we're prepped to merge the release branch to main once the RC binaries go out. Once that happens, you can change the target for this PR and add those directories as well :)

schavis
schavis requested changes Oct 10, 2025
View reviewed changes
Copy link
Contributor

@schavis schavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to update the summary table for 1.21.x under content/vault/global/partials/important-changes/summary-tables

@schavis
Copy link
Contributor

schavis commented Oct 14, 2025

@kpcraig Approved the PR, but you need to change your merge target to main. The release branch merged last week when we released the RC.

@kpcraig kpcraig changed the base branch from vault/1.21.x to main October 14, 2025 20:16
@kpcraig
Copy link
Contributor Author

kpcraig commented Oct 14, 2025

gonna rebase and force push I think since clearly I confused git and github

@kpcraig kpcraig force-pushed the VAULT-37789/utc-rotation-manager branch from 7f5bb64 to 1c6d81e Compare October 14, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schavis schavis schavis approved these changes

Assignees

No one assigned

Labels

Vault IC Higher priority Vault content PR. Update relates to an important changes announcement. Vault Content update for Vault product docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kpcraig @schavis