Marshaling normalization for HMAC comparison #1141
Open
+14
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #903
Problem
When a Vault secret becomes empty, a
VaultStaticSecretwith the transformationexcludeRaw: trueand a set of targets set inrolloutRestartTargetsfields, triggers infinite restarts of target Pods.The cause of it seems to be the way VSO checks if the secrets has changed and must be updated, an specifically:
excludeRaw: true) and thus VSO applies the patch withdata: {}since{}it's what is basically coming from Vault.datafield on the Secret since is empty.nilfor Kubernetes,{}for Vault) and the update process is repeated, triggering again the restart of the Pods.Changes
This PR normalizes HMAC computation to ensure consistent comparison between Vault and Kubernetes secrets.
If the secret’s data field is nil, it is now initialized to an empty map before computing the HMAC.
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.