Skip to content

PDB Availability Bugfix #1132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

PDB Availability Bugfix #1132

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a3c778
PDB Availability Bugfix
JohnLahr Oct 4, 2025
2f7e092
Merge branch 'main' into bugfix/pdb-availability
JohnLahr Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 27 additions & 24 deletions chart/templates/poddisruptionbudget.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,39 +7,42 @@ apiVersion: policy/v1
kind: PodDisruptionBudget
metadata:
name: {{ include "vso.chart.fullname" . }}
namespace: {{ .Release.Namespace }}
labels:
app.kubernetes.io/component: controller-manager
control-plane: controller-manager
{{- include "vso.chart.labels" . | nindent 4 }}
namespace: {{ .Release.Namespace }}
spec:
{{/* Throw an error if both maxUnavailable and minAvailable are set and non-zero */}}
{{- $maxUnavailable := toString .Values.controller.podDisruptionBudget.maxUnavailable | trim }}
{{- $minAvailable := toString .Values.controller.podDisruptionBudget.minAvailable | trim }}
{{- if and (not (empty $maxUnavailable)) (not (empty $minAvailable)) (ne $maxUnavailable "0") (ne $minAvailable "0") }}
{{- fail "You cannot set both maxUnavailable and minAvailable in the PodDisruptionBudget" }}
{{- end }}
{{- $rawMax := default "" .Values.controller.podDisruptionBudget.maxUnavailable -}}
{{- $rawMin := default "" .Values.controller.podDisruptionBudget.minAvailable -}}
{{- $max := toString $rawMax | trim -}}
{{- $min := toString $rawMin | trim -}}

{{/* If maxUnavailable is set, use it */}}
{{- if not (empty $maxUnavailable) }}
maxUnavailable:
{{- if contains "%" $maxUnavailable }}
"{{ $maxUnavailable }}"
{{- else }}
{{ $maxUnavailable }}
{{- end }}
{{- end }}
{{- /* Presence & zero-ness checks */ -}}
{{- $maxProvided := ne $max "" -}}
{{- $minProvided := ne $min "" -}}
{{- $maxZero := or (eq $max "0") (eq $max "0%") -}}
{{- $minZero := or (eq $min "0") (eq $min "0%") -}}
{{- $maxNonZero := and $maxProvided (not $maxZero) -}}
{{- $minNonZero := and $minProvided (not $minZero) -}}

{{/* If minAvailable is set, use it */}}
{{- if not (empty $minAvailable) }}
minAvailable:
{{- if contains "%" $minAvailable }}
"{{ $minAvailable }}"
{{- else }}
{{ $minAvailable }}
{{- end }}
{{- /* Hard stop only when both sides are non-zero (K8s forbids both keys at once) */ -}}
{{- if and $minNonZero $maxNonZero -}}
{{- fail "controller.podDisruptionBudget: you cannot set both maxUnavailable and minAvailable to non-zero values." -}}
{{- end }}

{{- /* Emit exactly one key */ -}}
{{- if $minNonZero }}
minAvailable:{{ if contains "%" $min }} "{{ $min }}"{{ else }} {{ $min }}{{ end }}
{{- else if $maxNonZero }}
maxUnavailable:{{ if contains "%" $max }} "{{ $max }}"{{ else }} {{ $max }}{{ end }}
{{- else if and $minProvided (not $maxProvided) }}
minAvailable:{{ if contains "%" $min }} "{{ $min }}"{{ else }} {{ $min }}{{ end }}
{{- else if and $maxProvided (not $minProvided) }}
maxUnavailable:{{ if contains "%" $max }} "{{ $max }}"{{ else }} {{ $max }}{{ end }}
{{- else }}
minAvailable: 1
{{- end }}
selector:
matchLabels:
{{- include "vso.chart.selectorLabels" . | nindent 6 }}
Expand Down