Skip to content

BuildUserAgent method support OS name parsing with and without spaces #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shettyprathik wants to merge 1 commit into
base: main
Choose a base branch
from
Open

BuildUserAgent method support OS name parsing with and without spaces #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion generate/templates/Configuration.handlebars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ namespace {{packageName}}.Client
public string BuildUserAgent()
{
StringBuilder sb = new StringBuilder("vault-client-dotnet/");
string OSName = RuntimeInformation.OSDescription.Substring(0, RuntimeInformation.OSDescription.IndexOf(" "));
string OSName = RuntimeInformation.OSDescription.Contains(" ") ? RuntimeInformation.OSDescription.Substring(0, RuntimeInformation.OSDescription.IndexOf(" ")) : RuntimeInformation.OSDescription;
sb.AppendFormat("{0} ({1} {2}; .Net {3})", Version, OSName, RuntimeInformation.ProcessArchitecture, System.Environment.Version);
return sb.ToString();
}
Expand Down
2 changes: 1 addition & 1 deletion src/Vault/Client/Configuration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ public string GetApiKeyWithPrefix(string apiKeyIdentifier)
public string BuildUserAgent()
{
StringBuilder sb = new StringBuilder("vault-client-dotnet/");
string OSName = RuntimeInformation.OSDescription.Substring(0, RuntimeInformation.OSDescription.IndexOf(" "));
string OSName = RuntimeInformation.OSDescription.Contains(" ") ? RuntimeInformation.OSDescription.Substring(0, RuntimeInformation.OSDescription.IndexOf(" ")) : RuntimeInformation.OSDescription;
sb.AppendFormat("{0} ({1} {2}; .Net {3})", Version, OSName, RuntimeInformation.ProcessArchitecture, System.Environment.Version);
return sb.ToString();
}
Expand Down