Skip to content

Backport of command/output: Ignore warnings in JSON mode into v1.15#38531

Merged
radeksimko merged 2 commits intov1.15from
backport/radek/ignore-warns-in-output-json/vigorously-organic-cougar
May 6, 2026
Merged

Backport of command/output: Ignore warnings in JSON mode into v1.15#38531
radeksimko merged 2 commits intov1.15from
backport/radek/ignore-warns-in-output-json/vigorously-organic-cougar

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented May 6, 2026

Backport

This PR is auto-generated from #38530 to be assessed for backporting due to the inclusion of the label 1.15-backport.

The below text is copied from the body of the original PR.


Fixes #38512
Closes #38513

Ideally we would just print out the diagnostics in the JSON mode, like we do in other JSON formatted output from other commands, but as @SarahFrench pointed out, this cannot be done easily (without breaking changes) since the format does not currently support versioning and doesn't allow for easy expansion:

{
	"foo":{
		"sensitive":false,
		"type":"string",
		"value":"bar"
	}
}

If we were to break things in the future and introduce the diagnostics, the likely format would be something like this:

{
  "format_version": "1.0",
  "outputs": {
    "greeting": {
        "sensitive": false,
        "type": "string",
        "value": "hello world"
    }
  },
  "diagnostics": []
}

Target Release

1.15.x

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

Overview of commits

@github-actions github-actions Bot requested a review from radeksimko May 6, 2026 09:27
@radeksimko radeksimko marked this pull request as ready for review May 6, 2026 09:29
@radeksimko radeksimko requested a review from a team as a code owner May 6, 2026 09:29
@radeksimko radeksimko enabled auto-merge (squash) May 6, 2026 09:35
@radeksimko radeksimko merged commit 60d9aee into v1.15 May 6, 2026
7 checks passed
@radeksimko radeksimko deleted the backport/radek/ignore-warns-in-output-json/vigorously-organic-cougar branch May 6, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant