Backport of command/output: Ignore warnings in JSON mode into v1.15#38531
Merged
radeksimko merged 2 commits intov1.15from May 6, 2026
Merged
Conversation
radeksimko
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #38530 to be assessed for backporting due to the inclusion of the label 1.15-backport.
The below text is copied from the body of the original PR.
Fixes #38512
Closes #38513
Ideally we would just print out the diagnostics in the JSON mode, like we do in other JSON formatted output from other commands, but as @SarahFrench pointed out, this cannot be done easily (without breaking changes) since the format does not currently support versioning and doesn't allow for easy expansion:
{ "foo":{ "sensitive":false, "type":"string", "value":"bar" } }If we were to break things in the future and introduce the diagnostics, the likely format would be something like this:
{ "format_version": "1.0", "outputs": { "greeting": { "sensitive": false, "type": "string", "value": "hello world" } }, "diagnostics": [] }Target Release
1.15.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry
Overview of commits
c34ce29
f2b45bb