Skip to content

Fix hide check scoped data sources #38389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sayeem3051 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix hide check scoped data sources #38389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f5a8a6a
command/jsonformat: hide check-scoped data sources from plan output
Sayeem3051 Apr 14, 2026
58a9196
Add bug fix entry for hiding check-scoped data sources
Sayeem3051 Apr 14, 2026
9e3dd04
command/jsonformat: skip check-scoped data sources before counting ch…
Sayeem3051 Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changes/v1.16/BUG FIXES-20260414-120000.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
kind: BUG FIXES
body: hide check-scoped data sources from plan output
time: 2026-04-14T12:00:00.000000-04:00
custom:
Issue: "36536"
12 changes: 12 additions & 0 deletions internal/command/jsonformat/plan.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,11 @@ func (plan Plan) renderHuman(renderer Renderer, mode plans.Mode, opts ...plans.Q
// Don't render anything for deleted data sources.
continue
}
// Skip data sources that are reloaded only for check block verification
if action == plans.Read && diff.change.Mode == jsonstate.DataResourceMode &&
diff.change.ActionReason == jsonplan.ResourceInstanceReadBecauseCheckNested {
continue
}

changes = append(changes, diff)

Expand Down Expand Up @@ -395,6 +400,13 @@ func renderHumanDiff(renderer Renderer, diff diff, cause string) (string, bool)
// Skip resource changes that have nothing interesting to say.
return "", false
}
// Skip data sources that are reloaded only for check block verification
if diff.change.Mode == jsonstate.DataResourceMode &&
diff.change.ActionReason == jsonplan.ResourceInstanceReadBecauseCheckNested &&
action == plans.Read {
return "", false
}


var buf bytes.Buffer
buf.WriteString(renderer.Colorize.Color(resourceChangeComment(diff.change, action, cause)))
Expand Down
Loading