Skip to content

Add support for openssh comments when generating a private key #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for openssh comments when generating a private key #395

wants to merge 1 commit into from

Conversation

@F21
Copy link

@F21 F21 commented Aug 3, 2023 •
edited
Loading

This PR adds the openssh_comment attribute to allow the addition of a comment to openssh keys.

Closes #227

@F21 F21 requested a review from a team as a code owner August 3, 2023 09:39
@github-actions github-actions bot added the size/S label Aug 3, 2023
@F21 F21 force-pushed the openssh-comment branch from 24eeba8 to ee44ae8 Compare August 3, 2023 09:44
@github-actions github-actions bot added size/M and removed size/S labels Aug 3, 2023
@F21 F21 force-pushed the openssh-comment branch 2 times, most recently from 04b4659 to cc4909c Compare August 3, 2023 23:52
@sestegra sestegra mentioned this pull request Sep 1, 2023
Merged
@F21 F21 force-pushed the openssh-comment branch from 672b916 to fe467f9 Compare October 17, 2023 22:22
@aalvarezaph
Copy link

aalvarezaph commented Nov 30, 2023

Any news? Would be useful for scenarios like #227 (comment)

@srgustafson8
Copy link

srgustafson8 commented Dec 13, 2023

Agreed - exactly the same use case I have. Can @bendbennett @bflad help (as the most prolific contributors)?

@F21 F21 force-pushed the openssh-comment branch from fe467f9 to 0551ac8 Compare March 10, 2024 23:23
@socratesx-asimov
Copy link

socratesx-asimov commented Mar 15, 2024

Come on guys please, this is what we also need.

@lavahot lavahot mentioned this pull request May 20, 2024
Open
1 task
@F21 F21 force-pushed the openssh-comment branch from 0551ac8 to 1752d24 Compare November 6, 2024 22:12
@F21 F21 force-pushed the openssh-comment branch 2 times, most recently from 1752d24 to 4dfafd0 Compare January 22, 2025 22:07
@F21 F21 force-pushed the openssh-comment branch from 4dfafd0 to 90dd1d4 Compare March 13, 2025 20:50
@F21 F21 force-pushed the openssh-comment branch from 90dd1d4 to b49f704 Compare April 16, 2025 23:24
@F21 F21 force-pushed the openssh-comment branch from b49f704 to 8eb284e Compare April 25, 2025 04:36
@F21 F21 force-pushed the openssh-comment branch from 8eb284e to 07b16d1 Compare July 28, 2025 03:45
@F21 F21 requested a review from a team as a code owner July 28, 2025 03:45
@F21 F21 force-pushed the openssh-comment branch from 07b16d1 to a8a9fa4 Compare August 7, 2025 22:44
@F21
Copy link
Author

F21 commented Aug 7, 2025

Can this be reviewed?

stephybun
stephybun requested changes Oct 10, 2025
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @F21! Overall this looks great, there are two minor comments which would be good to have addressed. Once that's done and the PR is rebased I can run the CI on this and we should be good to go!

@F21 F21 force-pushed the openssh-comment branch from a8a9fa4 to a533ab6 Compare October 11, 2025 08:27
@F21
Copy link
Author

F21 commented Oct 11, 2025 •
edited
Loading

Thanks for the review @stephybun ! I removed the openssh_comment attribute from data.tls_public_key as it doesn't make sense, so the openssh comment for public keys is now parsed from the private key.

I also implemented openssh_comment in the ephemeral versions of the resources.

@F21 F21 force-pushed the openssh-comment branch from a533ab6 to c2b3166 Compare October 11, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephybun stephybun stephybun requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

size/M size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow specifying OpenSSH Private Key Comment

7 participants

@F21 @aalvarezaph @srgustafson8 @socratesx-asimov @stephybun @bendbennett @hc-github-team-tf-provider-devex