-
Notifications
You must be signed in to change notification settings - Fork 9.9k
doc: mark Bedrock CloudWatch role_arn as required instead of optional #45469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: mark Bedrock CloudWatch role_arn as required instead of optional #45469
Conversation
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
|
API docs say Required: https://docs.aws.amazon.com/bedrock/latest/APIReference/API_CloudWatchConfig.html. |
…onfig.s3_config.bucket_name`, `logging_config.cloudwatch_config.log_group_name`, `logging_config.cloudwatch_config.role_arn`, and `logging_config.cloudwatch_config.large_data_delivery_s3_config.bucket_name` as Required.
…port v6.0.0 upgrade tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccBedrock_serial/ModelInvocationLoggingConfiguration' PKG=bedrock
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 HEAD 🌿...
TF_ACC=1 go1.24.11 test ./internal/service/bedrock/... -v -count 1 -parallel 20 -run=TestAccBedrock_serial/ModelInvocationLoggingConfiguration -timeout 360m -vet=off
2025/12/08 08:49:00 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/08 08:49:00 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN TestAccBedrock_serial
=== PAUSE TestAccBedrock_serial
=== CONT TestAccBedrock_serial
=== RUN TestAccBedrock_serial/ModelInvocationLoggingConfiguration
=== RUN TestAccBedrock_serial/ModelInvocationLoggingConfiguration/Identity
=== RUN TestAccBedrock_serial/ModelInvocationLoggingConfiguration/Identity/basic
=== RUN TestAccBedrock_serial/ModelInvocationLoggingConfiguration/Identity/ExistingResource
=== RUN TestAccBedrock_serial/ModelInvocationLoggingConfiguration/Identity/ExistingResourceNoRefresh
=== RUN TestAccBedrock_serial/ModelInvocationLoggingConfiguration/Identity/RegionOverride
=== RUN TestAccBedrock_serial/ModelInvocationLoggingConfiguration/basic
=== RUN TestAccBedrock_serial/ModelInvocationLoggingConfiguration/disappears
=== RUN TestAccBedrock_serial/ModelInvocationLoggingConfiguration/upgradeV6.0.0
--- PASS: TestAccBedrock_serial (367.60s)
--- PASS: TestAccBedrock_serial/ModelInvocationLoggingConfiguration (367.60s)
--- PASS: TestAccBedrock_serial/ModelInvocationLoggingConfiguration/Identity (235.53s)
--- PASS: TestAccBedrock_serial/ModelInvocationLoggingConfiguration/Identity/basic (40.40s)
--- PASS: TestAccBedrock_serial/ModelInvocationLoggingConfiguration/Identity/ExistingResource (100.78s)
--- PASS: TestAccBedrock_serial/ModelInvocationLoggingConfiguration/Identity/ExistingResourceNoRefresh (57.11s)
--- PASS: TestAccBedrock_serial/ModelInvocationLoggingConfiguration/Identity/RegionOverride (37.24s)
--- PASS: TestAccBedrock_serial/ModelInvocationLoggingConfiguration/basic (42.68s)
--- PASS: TestAccBedrock_serial/ModelInvocationLoggingConfiguration/disappears (27.25s)
--- PASS: TestAccBedrock_serial/ModelInvocationLoggingConfiguration/upgradeV6.0.0 (62.14s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/bedrock 373.158s|
After #42307 was merged hashicorp/terraform-plugin-framework#740 no longer applies so we can mark additional attributes as Required in the resource's schema. |
johnsonaj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
|
@sabithamuppuri Thanks for the contribution 🎉 👏. |
|
Warning This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them. Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed. |
|
This functionality has been released in v6.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Summary
This PR updates the documentation for the
aws_bedrock_model_invocation_logging_configurationresource to correctly identify thecloudwatch_config.role_arnargument as required.The AWS API for
PutModelInvocationLoggingConfigurationfails when this field is omitted, returning a validation error:The current documentation lists this argument as optional, which does not
match the behavior of the service API and leads to user confusion. This update
ensures the provider documentation accurately reflects the API requirements.
Notes