Skip to content

Conversation

@sabithamuppuri
Copy link

Summary

This PR updates the documentation for the
aws_bedrock_model_invocation_logging_configuration resource to correctly identify the cloudwatch_config.role_arn argument as required.

The AWS API for PutModelInvocationLoggingConfiguration fails when this field is omitted, returning a validation error:

operation error Bedrock: PutModelInvocationLoggingConfiguration, 1 validation error(s) found.
│ - missing required field, PutModelInvocationLoggingConfigurationInput.LoggingConfig.CloudWatchConfig.RoleArn.

The current documentation lists this argument as optional, which does not
match the behavior of the service API and leads to user confusion. This update
ensures the provider documentation accurately reflects the API requirements.

Notes

  • Documentation-only change.
  • No functional changes to the provider.
  • No tests required.

@sabithamuppuri sabithamuppuri requested a review from a team as a code owner December 6, 2025 03:27
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/bedrock Issues and PRs that pertain to the bedrock service. size/XS Managed by automation to categorize the size of a PR. labels Dec 6, 2025
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Dec 8, 2025
@ewbankkit
Copy link
Contributor

…onfig.s3_config.bucket_name`, `logging_config.cloudwatch_config.log_group_name`, `logging_config.cloudwatch_config.role_arn`, and `logging_config.cloudwatch_config.large_data_delivery_s3_config.bucket_name` as Required.
@ewbankkit ewbankkit self-assigned this Dec 8, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 8, 2025
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Dec 8, 2025
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccBedrock_serial/ModelInvocationLoggingConfiguration' PKG=bedrock
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 HEAD 🌿...
TF_ACC=1 go1.24.11 test ./internal/service/bedrock/... -v -count 1 -parallel 20  -run=TestAccBedrock_serial/ModelInvocationLoggingConfiguration -timeout 360m -vet=off
2025/12/08 08:49:00 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/08 08:49:00 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccBedrock_serial
=== PAUSE TestAccBedrock_serial
=== CONT  TestAccBedrock_serial
=== RUN   TestAccBedrock_serial/ModelInvocationLoggingConfiguration
=== RUN   TestAccBedrock_serial/ModelInvocationLoggingConfiguration/Identity
=== RUN   TestAccBedrock_serial/ModelInvocationLoggingConfiguration/Identity/basic
=== RUN   TestAccBedrock_serial/ModelInvocationLoggingConfiguration/Identity/ExistingResource
=== RUN   TestAccBedrock_serial/ModelInvocationLoggingConfiguration/Identity/ExistingResourceNoRefresh
=== RUN   TestAccBedrock_serial/ModelInvocationLoggingConfiguration/Identity/RegionOverride
=== RUN   TestAccBedrock_serial/ModelInvocationLoggingConfiguration/basic
=== RUN   TestAccBedrock_serial/ModelInvocationLoggingConfiguration/disappears
=== RUN   TestAccBedrock_serial/ModelInvocationLoggingConfiguration/upgradeV6.0.0
--- PASS: TestAccBedrock_serial (367.60s)
    --- PASS: TestAccBedrock_serial/ModelInvocationLoggingConfiguration (367.60s)
        --- PASS: TestAccBedrock_serial/ModelInvocationLoggingConfiguration/Identity (235.53s)
            --- PASS: TestAccBedrock_serial/ModelInvocationLoggingConfiguration/Identity/basic (40.40s)
            --- PASS: TestAccBedrock_serial/ModelInvocationLoggingConfiguration/Identity/ExistingResource (100.78s)
            --- PASS: TestAccBedrock_serial/ModelInvocationLoggingConfiguration/Identity/ExistingResourceNoRefresh (57.11s)
            --- PASS: TestAccBedrock_serial/ModelInvocationLoggingConfiguration/Identity/RegionOverride (37.24s)
        --- PASS: TestAccBedrock_serial/ModelInvocationLoggingConfiguration/basic (42.68s)
        --- PASS: TestAccBedrock_serial/ModelInvocationLoggingConfiguration/disappears (27.25s)
        --- PASS: TestAccBedrock_serial/ModelInvocationLoggingConfiguration/upgradeV6.0.0 (62.14s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/bedrock	373.158s

@ewbankkit
Copy link
Contributor

After #42307 was merged hashicorp/terraform-plugin-framework#740 no longer applies so we can mark additional attributes as Required in the resource's schema.

Copy link
Member

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit
Copy link
Contributor

@sabithamuppuri Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 5265262 into hashicorp:main Dec 8, 2025
44 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v6.26.0 milestone Dec 8, 2025
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 10, 2025
@github-actions
Copy link
Contributor

This functionality has been released in v6.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Introduces or discusses updates to documentation. service/bedrock Issues and PRs that pertain to the bedrock service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants