Skip to content

Conversation

@YakDriver
Copy link
Member

@YakDriver YakDriver commented Dec 5, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

This allows you to fix/scan PRs super easy, barely an inconvenience:

  • make copyright-fix PKG=s3 fixes for you
  • included when you run make quick-fix PKG=ec2 fixes along with other quick fixes
  • make copyright PKG=lambda to scan
  • make copyright-fix to do the whole repo

Repository Information

  • Repository: terraform-provider-aws
  • Repository Type: non-product
  • First commit year: 2014
  • Latest commit year: 2025
  • JIRA Ticket: IND-4227

Frequently Asked Questions

I have a file or folder which should be exempted, how do I do that? You may exempt certain files or folders from being scanned by adding a `.copywrite.hcl` config in the root of your repo. You can use the [`copywrite init`](https://go.hashi.co/copywrite) command to interactively create a config for this project.

An example schema can be found below. Add a doublestar**-capable pattern to the header_ignore list to skip it in future scans.

# (OPTIONAL) Overrides the copywrite config schema version
# Default: 1
schema_version = 1

project {
  # (OPTIONAL) SPDX-compatible license identifier
  # Leave blank if you don't wish to license the project
  # Default: "MPL-2.0"
  # license = ""

  # (OPTIONAL) Represents the year that the project initially began
  # Default: <the year the repo was first created>
  # copyright_year = 0

  # (OPTIONAL) A list of globs that should not have copyright or license headers .
  # Supports doublestar glob patterns for more flexibility in defining which
  # files or folders should be ignored
  # Default: []
  header_ignore = [
    # "vendor/**",
    # "**autogen**",
  ]
}

More information about configuration options is available in [the documentation](https://github.com/hashicorp/copywrite#config-structure).

Additional FAQs are available at https://go.hashi.co/header-faq

Please approve and merge this PR in a timely manner to keep this source code compliant with our OSS license agreement. If you have any questions or feedback, reach out to #proj-software-copyright.

Relations

Closes #0000

References

Output from Acceptance Testing

% make smoke
make: Sane Smoke Tests (x tests of Top y resources)
make: Like 'sanity' except full output and stops soon after 1st error
make: NOTE: NOT an exhaustive set of tests! Finds big problems only.
2025/12/05 12:43:07 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/05 12:43:07 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccIAMInstanceProfile_tags
=== PAUSE TestAccIAMInstanceProfile_tags
=== RUN   TestAccIAMInstanceProfile_basic
=== PAUSE TestAccIAMInstanceProfile_basic
=== RUN   TestAccIAMPolicyDocumentDataSource_basic
=== PAUSE TestAccIAMPolicyDocumentDataSource_basic
=== RUN   TestAccIAMPolicyDocumentDataSource_sourceConflicting
=== PAUSE TestAccIAMPolicyDocumentDataSource_sourceConflicting
=== RUN   TestAccIAMPolicy_tags
=== PAUSE TestAccIAMPolicy_tags
=== RUN   TestAccIAMPolicy_basic
=== PAUSE TestAccIAMPolicy_basic
=== RUN   TestAccIAMPolicy_policy
=== PAUSE TestAccIAMPolicy_policy
=== RUN   TestAccIAMRolePolicyAttachment_basic
=== PAUSE TestAccIAMRolePolicyAttachment_basic
=== RUN   TestAccIAMRolePolicyAttachment_disappears
=== PAUSE TestAccIAMRolePolicyAttachment_disappears
=== RUN   TestAccIAMRolePolicyAttachment_Disappears_role
=== PAUSE TestAccIAMRolePolicyAttachment_Disappears_role
=== RUN   TestAccIAMRolePolicy_basic
=== PAUSE TestAccIAMRolePolicy_basic
=== RUN   TestAccIAMRolePolicy_unknownsInPolicy
=== PAUSE TestAccIAMRolePolicy_unknownsInPolicy
=== RUN   TestAccIAMRole_basic
=== PAUSE TestAccIAMRole_basic
=== RUN   TestAccIAMRole_namePrefix
=== PAUSE TestAccIAMRole_namePrefix
=== RUN   TestAccIAMRole_disappears
=== PAUSE TestAccIAMRole_disappears
=== RUN   TestAccIAMRole_InlinePolicy_basic
=== PAUSE TestAccIAMRole_InlinePolicy_basic
=== CONT  TestAccIAMInstanceProfile_tags
=== CONT  TestAccIAMRole_InlinePolicy_basic
=== CONT  TestAccIAMRole_basic
=== CONT  TestAccIAMPolicy_tags
=== CONT  TestAccIAMRolePolicy_basic
=== CONT  TestAccIAMPolicy_policy
=== CONT  TestAccIAMRolePolicyAttachment_basic
=== CONT  TestAccIAMPolicy_basic
=== CONT  TestAccIAMPolicyDocumentDataSource_basic
=== CONT  TestAccIAMPolicyDocumentDataSource_sourceConflicting
=== CONT  TestAccIAMRolePolicy_unknownsInPolicy
=== CONT  TestAccIAMRole_disappears
=== CONT  TestAccIAMRole_namePrefix
=== CONT  TestAccIAMInstanceProfile_basic
=== CONT  TestAccIAMRolePolicyAttachment_disappears
=== CONT  TestAccIAMRolePolicyAttachment_Disappears_role
--- PASS: TestAccIAMPolicyDocumentDataSource_sourceConflicting (15.33s)
--- PASS: TestAccIAMPolicyDocumentDataSource_basic (15.35s)
--- PASS: TestAccIAMRole_disappears (19.35s)
--- PASS: TestAccIAMRolePolicyAttachment_disappears (20.00s)
--- PASS: TestAccIAMRolePolicyAttachment_Disappears_role (20.27s)
--- PASS: TestAccIAMPolicy_basic (21.75s)
--- PASS: TestAccIAMRole_namePrefix (21.83s)
--- PASS: TestAccIAMRolePolicy_basic (22.01s)
--- PASS: TestAccIAMRole_basic (22.30s)
--- PASS: TestAccIAMRolePolicy_unknownsInPolicy (23.81s)
--- PASS: TestAccIAMInstanceProfile_basic (26.34s)
--- PASS: TestAccIAMPolicy_policy (30.50s)
--- PASS: TestAccIAMRolePolicyAttachment_basic (30.82s)
--- PASS: TestAccIAMRole_InlinePolicy_basic (39.18s)
--- PASS: TestAccIAMPolicy_tags (58.46s)
--- PASS: TestAccIAMInstanceProfile_tags (78.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	85.372s
2025/12/05 12:45:06 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/05 12:45:06 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccLogsLogGroup_basic
=== PAUSE TestAccLogsLogGroup_basic
=== RUN   TestAccLogsLogGroup_multiple
=== PAUSE TestAccLogsLogGroup_multiple
=== CONT  TestAccLogsLogGroup_basic
=== CONT  TestAccLogsLogGroup_multiple
--- PASS: TestAccLogsLogGroup_multiple (13.88s)
--- PASS: TestAccLogsLogGroup_basic (17.48s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/logs	23.988s
2025/12/05 12:45:11 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/05 12:45:11 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccVPCDataSource_basic
=== PAUSE TestAccVPCDataSource_basic
=== RUN   TestAccVPCRouteTableAssociation_Subnet_basic
=== PAUSE TestAccVPCRouteTableAssociation_Subnet_basic
=== RUN   TestAccVPCRouteTable_basic
=== PAUSE TestAccVPCRouteTable_basic
=== RUN   TestAccVPCSecurityGroupRule_race
=== PAUSE TestAccVPCSecurityGroupRule_race
=== RUN   TestAccVPCSecurityGroupRule_protocolChange
=== PAUSE TestAccVPCSecurityGroupRule_protocolChange
=== RUN   TestAccVPCSecurityGroup_basic
=== PAUSE TestAccVPCSecurityGroup_basic
=== RUN   TestAccVPCSecurityGroup_egressMode
=== PAUSE TestAccVPCSecurityGroup_egressMode
=== RUN   TestAccVPCSecurityGroup_vpcAllEgress
=== PAUSE TestAccVPCSecurityGroup_vpcAllEgress
=== RUN   TestAccVPCSubnet_basic
=== PAUSE TestAccVPCSubnet_basic
=== RUN   TestAccVPC_tenancy
=== PAUSE TestAccVPC_tenancy
=== CONT  TestAccVPCDataSource_basic
=== CONT  TestAccVPCSecurityGroup_basic
=== CONT  TestAccVPCSecurityGroupRule_race
=== CONT  TestAccVPCSubnet_basic
=== CONT  TestAccVPC_tenancy
=== CONT  TestAccVPCSecurityGroup_vpcAllEgress
=== CONT  TestAccVPCRouteTable_basic
=== CONT  TestAccVPCRouteTableAssociation_Subnet_basic
=== CONT  TestAccVPCSecurityGroup_egressMode
=== CONT  TestAccVPCSecurityGroupRule_protocolChange
--- PASS: TestAccVPCSubnet_basic (24.29s)
--- PASS: TestAccVPCRouteTable_basic (24.50s)
--- PASS: TestAccVPCSecurityGroup_basic (26.84s)
--- PASS: TestAccVPCSecurityGroup_vpcAllEgress (27.12s)
--- PASS: TestAccVPCRouteTableAssociation_Subnet_basic (28.05s)
--- PASS: TestAccVPCDataSource_basic (32.15s)
--- PASS: TestAccVPCSecurityGroup_egressMode (49.22s)
--- PASS: TestAccVPC_tenancy (53.80s)
--- PASS: TestAccVPCSecurityGroupRule_protocolChange (58.25s)
--- PASS: TestAccVPCSecurityGroupRule_race (180.29s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	191.601s
2025/12/05 12:45:15 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/05 12:45:15 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccECSService_basic
=== PAUSE TestAccECSService_basic
=== RUN   TestAccECSTaskDefinition_basic
=== PAUSE TestAccECSTaskDefinition_basic
=== CONT  TestAccECSService_basic
=== CONT  TestAccECSTaskDefinition_basic
--- PASS: TestAccECSTaskDefinition_basic (25.06s)
--- PASS: TestAccECSService_basic (75.83s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	91.832s
?   	github.com/hashicorp/terraform-provider-aws/internal/service/ecs/test-fixtures	[no test files]
2025/12/05 12:45:25 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/05 12:45:25 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccELBV2TargetGroup_basic
=== PAUSE TestAccELBV2TargetGroup_basic
=== CONT  TestAccELBV2TargetGroup_basic
--- PASS: TestAccELBV2TargetGroup_basic (21.41s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	46.463s
2025/12/05 12:45:20 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/05 12:45:20 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccKMSKey_basic
=== PAUSE TestAccKMSKey_basic
=== CONT  TestAccKMSKey_basic
--- PASS: TestAccKMSKey_basic (29.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kms	49.730s
2025/12/05 12:48:36 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/05 12:48:36 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccLambdaFunction_basic
=== PAUSE TestAccLambdaFunction_basic
=== RUN   TestAccLambdaPermission_basic
=== PAUSE TestAccLambdaPermission_basic
=== CONT  TestAccLambdaFunction_basic
=== CONT  TestAccLambdaPermission_basic
--- PASS: TestAccLambdaPermission_basic (37.76s)
--- PASS: TestAccLambdaFunction_basic (46.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	53.030s
2025/12/05 12:48:41 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/05 12:48:41 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccMetaPartitionDataSource_basic
=== PAUSE TestAccMetaPartitionDataSource_basic
=== RUN   TestAccMetaRegionDataSource_basic
=== PAUSE TestAccMetaRegionDataSource_basic
=== RUN   TestAccMetaRegionDataSource_endpoint
=== PAUSE TestAccMetaRegionDataSource_endpoint
=== CONT  TestAccMetaPartitionDataSource_basic
=== CONT  TestAccMetaRegionDataSource_endpoint
=== CONT  TestAccMetaRegionDataSource_basic
--- PASS: TestAccMetaPartitionDataSource_basic (11.04s)
--- PASS: TestAccMetaRegionDataSource_endpoint (11.08s)
--- PASS: TestAccMetaRegionDataSource_basic (11.75s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/meta	23.113s
2025/12/05 12:48:46 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/05 12:48:46 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccRoute53Record_basic
=== PAUSE TestAccRoute53Record_basic
=== RUN   TestAccRoute53Record_Latency_basic
=== PAUSE TestAccRoute53Record_Latency_basic
=== RUN   TestAccRoute53ZoneDataSource_name
=== PAUSE TestAccRoute53ZoneDataSource_name
=== CONT  TestAccRoute53Record_basic
=== CONT  TestAccRoute53ZoneDataSource_name
=== CONT  TestAccRoute53Record_Latency_basic
--- PASS: TestAccRoute53ZoneDataSource_name (73.58s)
--- PASS: TestAccRoute53Record_basic (138.19s)
--- PASS: TestAccRoute53Record_Latency_basic (138.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	154.192s
2025/12/05 12:48:51 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/05 12:48:51 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccS3BucketACL_updateACL
=== PAUSE TestAccS3BucketACL_updateACL
=== RUN   TestAccS3BucketPolicy_basic
=== PAUSE TestAccS3BucketPolicy_basic
=== RUN   TestAccS3BucketPublicAccessBlock_basic
=== PAUSE TestAccS3BucketPublicAccessBlock_basic
=== RUN   TestAccS3Bucket_Basic_basic
=== PAUSE TestAccS3Bucket_Basic_basic
=== RUN   TestAccS3Bucket_Security_corsUpdate
=== PAUSE TestAccS3Bucket_Security_corsUpdate
=== RUN   TestAccS3Object_basic
=== PAUSE TestAccS3Object_basic
=== CONT  TestAccS3BucketACL_updateACL
=== CONT  TestAccS3Bucket_Basic_basic
=== CONT  TestAccS3Object_basic
=== CONT  TestAccS3BucketPublicAccessBlock_basic
=== CONT  TestAccS3Bucket_Security_corsUpdate
=== CONT  TestAccS3BucketPolicy_basic
--- PASS: TestAccS3BucketPublicAccessBlock_basic (22.34s)
--- PASS: TestAccS3BucketPolicy_basic (22.81s)
--- PASS: TestAccS3Bucket_Basic_basic (23.12s)
--- PASS: TestAccS3Object_basic (25.23s)
--- PASS: TestAccS3BucketACL_updateACL (36.06s)
--- PASS: TestAccS3Bucket_Security_corsUpdate (38.12s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	55.354s
2025/12/05 12:48:55 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/05 12:48:56 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccSSMParameterEphemeral_basic
=== PAUSE TestAccSSMParameterEphemeral_basic
=== CONT  TestAccSSMParameterEphemeral_basic
--- PASS: TestAccSSMParameterEphemeral_basic (13.65s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssm	35.647s
2025/12/05 12:49:05 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/05 12:49:05 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccSecretsManagerSecret_basic
=== PAUSE TestAccSecretsManagerSecret_basic
=== CONT  TestAccSecretsManagerSecret_basic
--- PASS: TestAccSecretsManagerSecret_basic (15.53s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/secretsmanager	47.013s
2025/12/05 12:49:00 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/05 12:49:00 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccSTSCallerIdentityDataSource_basic
=== PAUSE TestAccSTSCallerIdentityDataSource_basic
=== CONT  TestAccSTSCallerIdentityDataSource_basic
--- PASS: TestAccSTSCallerIdentityDataSource_basic (10.13s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sts	36.831s

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 5, 2025
Files: 1001-1100 of 6292
Files: 1101-1200 of 6292
Files: 1201-1300 of 6292
Files: 1301-1400 of 6292
Files: 1401-1500 of 6292
Files: 1501-1600 of 6292
Files: 1601-1700 of 6292
Files: 1701-1800 of 6292
Files: 1801-1900 of 6292
Files: 1901-2000 of 6292
Files: 2001-2100 of 6292
Files: 2101-2200 of 6292
Files: 2201-2300 of 6292
Files: 2301-2400 of 6292
Files: 2401-2500 of 6292
@github-actions github-actions bot added service/dsql Issues and PRs that pertain to the dsql service. service/bedrockagentcore Issues and PRs that pertain to the bedrockagentcore service. service/arcregionswitch Issues and PRs that pertain to the arcregionswitch service. service/arczonalshift Issues and PRs that pertain to the arczonalshift service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. and removed service/dynamodb Issues and PRs that pertain to the dynamodb service. labels Dec 5, 2025
- Add .ci/scripts/copyright-fix.sh to fix/add copyright headers
- Add 'make copyright-fix' target
- Update generator templates to use IBM copyright
- Regenerate files with correct headers
- Added IBM copyright and SPDX license to 32 generator templates
- Regenerated all files with proper headers
- Add IBM copyright and SPDX as lines 1-2 to Oracle and Kubernetes files
- Remove exemptions from copyright scripts (no longer needed)
- All files now consistently have IBM copyright as first line
- Move SPDX to line 2, Twilio copyright to line 3
- Consistent with other third-party copyrights
- Update copyright-check.sh to handle Go, shell, HCL, Terraform, Python
- Update copyright-fix.sh to fix all file types with correct comment style
- Fix 2,123 non-Go files (shell scripts, HCL, Terraform, Python)
- Handle shebang lines correctly
- Use # comments for shell/HCL/TF/Python, // for Go
- Fix test.tf.gtpl templates to use IBM copyright
- Fix servicelabels template to use # comments (not //)
- Regenerate all Terraform test files with correct headers
- Fix semgrep templates to use # instead of //
- YAML files require # for comments, not //
- Regenerate all semgrep YAML files with correct syntax
- Fix issuelabels, prlabels, and servicesemgrep templates
- All YAML generators now use # comments
- Regenerate all YAML files with correct syntax
- Use HTML comments for markdown files
- Add headers to 261 documentation files
- Update copyright-check.sh to validate markdown files
- Move copyright to after --- frontmatter markers
- YAML frontmatter must be first in file
- Use HTML comments for markdown
- make copyright PKG=s3 checks only s3 service
- make copyright-fix K=ec2 fixes only ec2 service
- Speeds up development workflow
- Falls back to full check if no PKG/K specified
@YakDriver
Copy link
Member Author

YakDriver commented Dec 8, 2025

Copyright Migration Diff Summary

This PR migrates ~10,400 files from HashiCorp copyright to IBM copyright format.

Unique Diff Patterns

The changes follow 7 distinct patterns, making review straightforward:

Pattern 1: Go Files (6,294 files) - Simple copyright replacement

diff

-// Copyright (c) HashiCorp, Inc.
+// Copyright IBM Corp. 2014, 2025
// SPDX-License-Identifier: MPL-2.0

Pattern 2: Shell/HCL/Terraform/Python (2,123 files) - Comment style change

diff

-// Copyright (c) HashiCorp, Inc.
-// SPDX-License-Identifier: MPL-2.0
+# Copyright IBM Corp. 2014, 2025
+# SPDX-License-Identifier: MPL-2.0

Pattern 3: YAML Files (~50 files) - Fix comment style for YAML

diff

-// Copyright IBM Corp. 2014, 2025
-// SPDX-License-Identifier: MPL-2.0
+# Copyright IBM Corp. 2014, 2025
+# SPDX-License-Identifier: MPL-2.0

Pattern 4: Markdown Files (261 files) - HTML comments

diff

+<!-- Copyright IBM Corp. 2014, 2025 -->
+<!-- SPDX-License-Identifier: MPL-2.0 -->
+

Document Title

Pattern 5: Generator Templates (35 files)

Templates updated to generate correct comment style:

  • Go templates → // comments
  • Shell/HCL/TF templates → # comments
  • YAML templates → # comments
  • Markdown templates → <!-- --> comments

Pattern 6: Third-party Copyrights (3 files)

IBM copyright added before third-party (Oracle, Kubernetes, Twilio):
diff

+// Copyright IBM Corp. 2014, 2025
+// SPDX-License-Identifier: MPL-2.0
// Copyright 2025 Twilio Inc.

Pattern 7: Tooling (3 files)

New copyright infrastructure:

  • .ci/scripts/copyright-check.sh - Validates all file types
  • .ci/scripts/copyright-fix.sh - Fixes/adds headers (supports PKG=<service>)
  • GNUmakefile - New make copyright and make copyright-fix targets

File Type Breakdown

File Type Count Pattern
Go (*.go) 6,294 Pattern 1
Terraform (*.tf) 2,085 Pattern 2
Markdown (*.md) 261 Pattern 4
YAML (*.yml) ~50 Pattern 3
Shell (*.sh) 24 Pattern 2
HCL (*.hcl) 38 Pattern 2
Python (*.py) 4 Pattern 2
Templates 35 Pattern 5
Tooling 3 Pattern 7

Review Guidance

For bulk changes (99% of files): Sample 5-10 random files per pattern

  • ✅ Old copyright line removed
  • ✅ New IBM copyright added
  • ✅ SPDX license identifier intact

For generator templates: Verify correct comment style for output type

For tooling: Check logic handles all file types, skips generated files, preserves third-party copyrights

Edge cases to spot-check:

  • internal/service/odb/cloud_vm_clusters_data_source_test.go - Oracle copyright
  • internal/service/eks/token.go - Kubernetes copyright
  • internal/service/logs/transformer*.go - Twilio copyright
  • website/docs/guides/*.html.markdown - Copyright after YAML frontmatter

Testing

All changes validated by:

  • make copyright - Passes for all files
  • make gen - Regenerates files with correct headers
  • ✅ CI checks - YAML lint, markdown lint, tfproviderdocs

For PR Authors with Conflicts

Run make copyright-fix (or make copyright-fix PKG=<service> for single service) to automatically add IBM copyright headers to your files.

@github-actions
Copy link
Contributor

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client-connections Pertains to the AWS Client and service connections. create Pertains to generating names, hashcodes, etc. flex Pertains to FLatteners and EXpanders. function Pertains to provider functions. generators Relates to code generators. github_actions Pull requests that update Github_actions code linter Pertains to changes to or issues with the various linters. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. provider Pertains to the provider itself, rather than any interaction with AWS. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service. service/account Issues and PRs that pertain to the account service. service/acm Issues and PRs that pertain to the acm service. service/acmpca Issues and PRs that pertain to the acmpca service. service/amp Issues and PRs that pertain to the amp service. service/amplify Issues and PRs that pertain to the amplify service. service/apigateway Issues and PRs that pertain to the apigateway service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/appautoscaling Issues and PRs that pertain to the appautoscaling service. service/appconfig Issues and PRs that pertain to the appconfig service. service/appfabric Issues and PRs that pertain to the appfabric service. service/appflow Issues and PRs that pertain to the appflow service. service/appintegrations Issues and PRs that pertain to the appintegrations service. service/applicationinsights Issues and PRs that pertain to the applicationinsights service. service/applicationsignals Issues and PRs that pertain to the applicationsignals service. service/appmesh Issues and PRs that pertain to the appmesh service. service/apprunner Issues and PRs that pertain to the apprunner service. service/appstream Issues and PRs that pertain to the appstream service. service/appsync Issues and PRs that pertain to the appsync service. service/arcregionswitch Issues and PRs that pertain to the arcregionswitch service. service/arczonalshift Issues and PRs that pertain to the arczonalshift service. service/athena Issues and PRs that pertain to the athena service. service/auditmanager Issues and PRs that pertain to the auditmanager service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/autoscalingplans Issues and PRs that pertain to the autoscalingplans service. service/backup Issues and PRs that pertain to the backup service. service/batch Issues and PRs that pertain to the batch service. service/bcmdataexports Issues and PRs that pertain to the bcmdataexports service. service/bedrock Issues and PRs that pertain to the bedrock service. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. service/bedrockagentcore Issues and PRs that pertain to the bedrockagentcore service. service/billing Issues and PRs that pertain to the billing service. service/budgets Issues and PRs that pertain to the budgets service. service/ce Issues and PRs that pertain to the ce service. service/chatbot Issues and PRs that pertain to the chatbot service. service/chime Issues and PRs that pertain to the chime service. service/chimesdkmediapipelines Issues and PRs that pertain to the chimesdkmediapipelines service. service/chimesdkvoice Issues and PRs that pertain to the chimesdkvoice service. service/cleanrooms Issues and PRs that pertain to the cleanrooms service. service/cloud9 Issues and PRs that pertain to the cloud9 service. service/cloudcontrol Issues and PRs that pertain to the cloudcontrol service. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/cloudfront Issues and PRs that pertain to the cloudfront service. service/cloudfrontkeyvaluestore Issues and PRs that pertain to the cloudfrontkeyvaluestore service. service/cloudhsmv2 Issues and PRs that pertain to the cloudhsmv2 service. service/cloudsearch Issues and PRs that pertain to the cloudsearch service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/codeartifact Issues and PRs that pertain to the codeartifact service. service/codebuild Issues and PRs that pertain to the codebuild service. service/codecatalyst Issues and PRs that pertain to the codecatalyst service. service/codecommit Issues and PRs that pertain to the codecommit service. service/codeconnections Issues and PRs that pertain to the codeconnections service. service/codeguruprofiler Issues and PRs that pertain to the codeguruprofiler service. service/codegurureviewer Issues and PRs that pertain to the codegurureviewer service. service/codepipeline Issues and PRs that pertain to the codepipeline service. service/codestarconnections Issues and PRs that pertain to the codestarconnections service. service/codestarnotifications Issues and PRs that pertain to the codestarnotifications service. service/cognitoidentity Issues and PRs that pertain to the cognitoidentity service. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. service/comprehend Issues and PRs that pertain to the comprehend service. service/computeoptimizer Issues and PRs that pertain to the computeoptimizer service. service/configservice Issues and PRs that pertain to the configservice service. service/connect Issues and PRs that pertain to the connect service. service/connectcases Issues and PRs that pertain to the connectcases service. service/controltower Issues and PRs that pertain to the controltower service. service/costoptimizationhub Issues and PRs that pertain to the costoptimizationhub service. service/cur Issues and PRs that pertain to the cur service. service/customerprofiles Issues and PRs that pertain to the customerprofiles service. service/databrew Issues and PRs that pertain to the databrew service. service/dataexchange Issues and PRs that pertain to the dataexchange service. service/datapipeline Issues and PRs that pertain to the datapipeline service. service/datasync Issues and PRs that pertain to the datasync service. service/datazone Issues and PRs that pertain to the datazone service. service/dax Issues and PRs that pertain to the dax service. service/deploy Issues and PRs that pertain to the deploy service. service/detective Issues and PRs that pertain to the detective service. service/devicefarm Issues and PRs that pertain to the devicefarm service. service/devopsguru Issues and PRs that pertain to the devopsguru service. service/directconnect Issues and PRs that pertain to the directconnect service. service/dlm Issues and PRs that pertain to the dlm service. service/dms Issues and PRs that pertain to the dms service. service/docdb Issues and PRs that pertain to the docdb service. service/docdbelastic Issues and PRs that pertain to the docdbelastic service. service/drs Issues and PRs that pertain to the drs service. service/ds Issues and PRs that pertain to the ds service. service/dsql Issues and PRs that pertain to the dsql service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant