-
Notifications
You must be signed in to change notification settings - Fork 9.8k
copyright ibm migration #45458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copyright ibm migration #45458
Conversation
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
Files: 1-100 of 6292
Files: 101-200 of 6292
Files: 201-300 of 6292
Files: 301-400 of 6292
Files: 401-500 of 6292
Files: 501-600 of 6292
Files: 601-700 of 6292
Files: 701-800 of 6292
Files: 801-900 of 6292
Files: 901-1000 of 6292
Files: 1001-1100 of 6292
Files: 1101-1200 of 6292
Files: 1201-1300 of 6292
Files: 1301-1400 of 6292
Files: 1401-1500 of 6292
Files: 1501-1600 of 6292
Files: 1601-1700 of 6292
Files: 1701-1800 of 6292
Files: 1801-1900 of 6292
Files: 1901-2000 of 6292
Files: 2001-2100 of 6292
Files: 2101-2200 of 6292
Files: 2201-2300 of 6292
Files: 2301-2400 of 6292
Files: 2401-2500 of 6292
- Add .ci/scripts/copyright-fix.sh to fix/add copyright headers - Add 'make copyright-fix' target - Update generator templates to use IBM copyright - Regenerate files with correct headers
- Added IBM copyright and SPDX license to 32 generator templates - Regenerated all files with proper headers
- Add IBM copyright and SPDX as lines 1-2 to Oracle and Kubernetes files - Remove exemptions from copyright scripts (no longer needed) - All files now consistently have IBM copyright as first line
- Move SPDX to line 2, Twilio copyright to line 3 - Consistent with other third-party copyrights
- Update copyright-check.sh to handle Go, shell, HCL, Terraform, Python - Update copyright-fix.sh to fix all file types with correct comment style - Fix 2,123 non-Go files (shell scripts, HCL, Terraform, Python) - Handle shebang lines correctly - Use # comments for shell/HCL/TF/Python, // for Go
- Fix test.tf.gtpl templates to use IBM copyright - Fix servicelabels template to use # comments (not //) - Regenerate all Terraform test files with correct headers
- Fix semgrep templates to use # instead of // - YAML files require # for comments, not // - Regenerate all semgrep YAML files with correct syntax
- Fix issuelabels, prlabels, and servicesemgrep templates - All YAML generators now use # comments - Regenerate all YAML files with correct syntax
- Use HTML comments for markdown files - Add headers to 261 documentation files - Update copyright-check.sh to validate markdown files
- Move copyright to after --- frontmatter markers - YAML frontmatter must be first in file - Use HTML comments for markdown
- make copyright PKG=s3 checks only s3 service - make copyright-fix K=ec2 fixes only ec2 service - Speeds up development workflow - Falls back to full check if no PKG/K specified
Copyright Migration Diff SummaryThis PR migrates ~10,400 files from HashiCorp copyright to IBM copyright format. Unique Diff PatternsThe changes follow 7 distinct patterns, making review straightforward: Pattern 1: Go Files (6,294 files) - Simple copyright replacementdiff Pattern 2: Shell/HCL/Terraform/Python (2,123 files) - Comment style changediff Pattern 3: YAML Files (~50 files) - Fix comment style for YAMLdiff Pattern 4: Markdown Files (261 files) - HTML commentsdiff Document TitlePattern 5: Generator Templates (35 files)Templates updated to generate correct comment style:
Pattern 6: Third-party Copyrights (3 files)IBM copyright added before third-party (Oracle, Kubernetes, Twilio): Pattern 7: Tooling (3 files)New copyright infrastructure:
File Type Breakdown
Review GuidanceFor bulk changes (99% of files): Sample 5-10 random files per pattern
For generator templates: Verify correct comment style for output type For tooling: Check logic handles all file types, skips generated files, preserves third-party copyrights Edge cases to spot-check:
TestingAll changes validated by:
For PR Authors with ConflictsRun |
|
Warning This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them. Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed. |
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Description
This allows you to fix/scan PRs super easy, barely an inconvenience:
make copyright-fix PKG=s3fixes for youmake quick-fix PKG=ec2fixes along with other quick fixesmake copyright PKG=lambdato scanmake copyright-fixto do the whole repoRepository Information
Frequently Asked Questions
I have a file or folder which should be exempted, how do I do that?
You may exempt certain files or folders from being scanned by adding a `.copywrite.hcl` config in the root of your repo. You can use the [`copywrite init`](https://go.hashi.co/copywrite) command to interactively create a config for this project.An example schema can be found below. Add a doublestar**-capable pattern to the
header_ignorelist to skip it in future scans.Additional FAQs are available at https://go.hashi.co/header-faq
Please approve and merge this PR in a timely manner to keep this source code compliant with our OSS license agreement. If you have any questions or feedback, reach out to #proj-software-copyright.
Relations
Closes #0000
References
Output from Acceptance Testing