Skip to content

Conversation

@tabito-hara
Copy link
Contributor

@tabito-hara tabito-hara commented Dec 5, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

  • Accelerated recovery for Route 53 Zones was implemented in [Enhancement] aws_route53_zone: Add enable_accelerated_recovery argument #45302.
  • Due to an AWS API limitation, accelerated recovery can only be updated for one hosted zone at a time.
  • By using the GlobalMutexKV mechanism, operations to enable accelerated recovery are enforced to run serially when multiple hosted zones are configured.
  • The existing acceptance test (previously for a single hosted zone) has been updated to cover multiple hosted zones.

Relations

Closes #45452
Relates #45302

Output from Acceptance Testing

$ make testacc TESTS='TestAccRoute53Zone_(basic|enableAcceleratedRecovery)' PKG=route53
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 b-aws_route53_zone-accelerated_recovery_with_multiple_zones 🌿...
TF_ACC=1 go1.24.11 test ./internal/service/route53/... -v -count 1 -parallel 20 -run='TestAccRoute53Zone_(basic|enableAcceleratedRecovery)'  -timeout 360m -vet=off
2025/12/06 02:41:53 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/06 02:41:53 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccRoute53Zone_basic
=== PAUSE TestAccRoute53Zone_basic
=== RUN   TestAccRoute53Zone_enableAcceleratedRecovery
=== PAUSE TestAccRoute53Zone_enableAcceleratedRecovery
=== CONT  TestAccRoute53Zone_basic
=== CONT  TestAccRoute53Zone_enableAcceleratedRecovery
--- PASS: TestAccRoute53Zone_basic (94.99s)
--- PASS: TestAccRoute53Zone_enableAcceleratedRecovery (1982.87s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53    1986.959s

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/route53 Issues and PRs that pertain to the route53 service. size/M Managed by automation to categorize the size of a PR. labels Dec 5, 2025
@tabito-hara tabito-hara marked this pull request as ready for review December 5, 2025 18:16
@tabito-hara tabito-hara requested a review from a team as a code owner December 5, 2025 18:16
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 8, 2025
@ewbankkit ewbankkit self-assigned this Dec 8, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 8, 2025
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRoute53Zone_\(basic\|enableAcceleratedRecovery\)' PKG=route53 ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 HEAD 🌿...
TF_ACC=1 go1.24.11 test ./internal/service/route53/... -v -count 1 -parallel 3  -run=TestAccRoute53Zone_\(basic\|enableAcceleratedRecovery\) -timeout 360m -vet=off
2025/12/08 09:20:14 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/08 09:20:14 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccRoute53Zone_basic
=== PAUSE TestAccRoute53Zone_basic
=== RUN   TestAccRoute53Zone_enableAcceleratedRecovery
=== PAUSE TestAccRoute53Zone_enableAcceleratedRecovery
=== CONT  TestAccRoute53Zone_basic
=== CONT  TestAccRoute53Zone_enableAcceleratedRecovery
--- PASS: TestAccRoute53Zone_basic (81.59s)
--- PASS: TestAccRoute53Zone_enableAcceleratedRecovery (2584.02s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	2589.397s

@ewbankkit
Copy link
Contributor

@tabito-hara Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit e65e689 into hashicorp:main Dec 8, 2025
44 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v6.26.0 milestone Dec 8, 2025
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 10, 2025
@github-actions
Copy link
Contributor

This functionality has been released in v6.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Addresses a defect in current functionality. service/route53 Issues and PRs that pertain to the route53 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

provider fails to update enable_accelerated_recovery in route53 hosted zone

2 participants